Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] [WIP] Text.Json OpenTk.Mathematics serialization support. #1273

Open
wants to merge 12 commits into
base: opentk5.0
Choose a base branch
from

Conversation

Rainboi64
Copy link

Purpose of this PR

  • Adding OpenTk.Mathematics serialization support for System.Text.Json
  • Will be achieved by adding the right attributes to properties and fields to the members of OpenTk.Mathematics.
  • In the end this will make a seamless experience for serializing/deserializing, without anymore code needed.

Testing status

  • Will be tested against randomly generated data across big sample sizes.
  • Results will be compared to results by other tools and libraries.
  • Will be Tested with personal projects.

Comments

  • I decided to retarget this to Otk5 since it's the future of opentk and, also considering the fact that doing it with the old targets requires too much fussing and creating numerous converter classes.

@frederikja163
Copy link
Member

This seems like a very nice addition. Cant wait to get it merged once it is done!

@NogginBops NogginBops changed the title [Otk5] [WIP] Text.Json OpenTk.Mathematics serialization support. [5.0] [WIP] Text.Json OpenTk.Mathematics serialization support. May 19, 2021
@NogginBops NogginBops added the 5.x label May 22, 2021
@NogginBops
Copy link
Member

Is there really no way to disable serialization of properties for a specific type in Text.Json?
It's very error prone to add it manually to all properties, but if that is the only way then there is not much we can do...

@NogginBops NogginBops force-pushed the opentk5.0 branch 2 times, most recently from 416a63a to b57b01c Compare October 28, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants