Configure the control to allow transparency #71
Conversation
src/GLWpfControl/DxGLFramebuffer.cs
Outdated
| Format.X8R8G8B8,// this is like A8 R8 G8 B8, but avoids issues with Gamma correction being applied twice. | ||
| format,// this is like A8 R8 G8 B8, but avoids issues with Gamma correction being applied twice. |
There was a problem hiding this comment.
How does this comment hold up? Is gamma correction applied twice with the A8R8G8B8 format?
There was a problem hiding this comment.
I am not sure what that comment is referring to. Enabling automatic gamma correction by including GL.Enable(EnableCap.FramebufferSrgb); on the example, does not have any effect on final render. But just in case, this is reasoning behind making this format configurable.
There was a problem hiding this comment.
I have removed this comment on my last commit. If there is a specific example where gamma correction is a problem, I could take a look.
|
I'm still slightly suspicious of the gamma thing, hopefully varon can answer what that was about. Really appreciate the PR, hopefully I'll have some time soon to make a new release of this package with this PR in it. |
|
This is a fantastic addition! Could we hope to see this merged soon? Thanks to you both. |
|
I will merge this, and if this results in gamma issues I hope that people will open an issue here so we can fix it in that case. |
Issue 59
Changing the frame buffer format to
A8R8G8B8, the alpha channel of the color passed to the function GL.ClearColor will determine now the level of transparency of the control.