Updated PackageReference from 4.7.5 to 4.8.0.
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
To update these references you also need to update the version in the Updating this version will fix the nuget package version range. |
|
My new laptop charger is on its way, express shipping. Once it comes around I'll make this change and hopefully we can update the package :) |
Closed
Closed
|
@softwareantics ping if you forgot this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PackageReferenceforGLWpfControl.csproj.PackageReferenceforExample.csproj.Fixes #114
Dependencies
Type of change
How Has This Been Tested?
I tested the example locally on my machine and everything still needs to be working. Furthermore, I created my own local package and tested it in my own personal project to make sure that I would no longer receive the warnings described in #114.
Test Configuration:
Possible Issues
I don't know if this will directly fix the issue once a new release is made. I think there is something that the maintainers of the NuGet package will have to address unless I can be pointed in the right direction. When uploading my own package of the control to NuGet instead of checking if the version was between 4.3.0 and 5.0.0 it ensured that it was greater than or equal to 4.8.0.