Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the PackageReference for OpenTK to 4.8.0. #114

Open
softwareantics opened this issue Aug 12, 2023 · 1 comment · May be fixed by #115
Open

Update the PackageReference for OpenTK to 4.8.0. #114

softwareantics opened this issue Aug 12, 2023 · 1 comment · May be fixed by #115

Comments

@softwareantics
Copy link
Contributor

Description

I propose we update the PackageReference for OpenTK to 4.8.0 as it is the latest stable release.

<PackageReference Include="OpenTK" Version="4.7.5" />

We should also likely update the paket?

OpenTK ~> 4.0 >= 4.3.0

The Why

This will hopefully resolve an issue where users are referencing GLWpfControl and getting a NU1608 warning about the current reference of OpenTK needing to be fixed.

image

However, I'm a little confused because the NuGet package dependencies show >= 4.3.0 && < 5.0.0

image

The How

I believe just updating the PackageReference and uploading a new package with the correct constraints should fix this issue.

@softwareantics softwareantics linked a pull request Aug 12, 2023 that will close this issue
1 task
@NogginBops
Copy link
Member

I think that maybe the paket line should be OpenTK ~> 4 >= 4.8.0? So that it becomes >= 4.8.0 && < 5.0.0, but I'm not 100% sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants