Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwiftUI App #2

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

SwiftUI App #2

wants to merge 35 commits into from

Conversation

landonr
Copy link

@landonr landonr commented Nov 4, 2023 •
edited

OpenTweet.mov

In SwiftUI

If you want to see my UIKit code, you can see this take home test Fightcamp Takehome

Features

  • Timeline view
  • Everything is selectable
  • Tweet detail view
    • Shows tweet in reply to
    • Shows tweet replies
    • Shows tweet threads (up to 2 levels deep)
  • User Profile view
  • Tapping links opens in safari
  • Tapping mentions navigates to users
  • Unit and UI Tests

To Improve

  • Use NavigationPath for more complex navigation management
    • Mentions always at the top of the root stack
    • If you open a tweet that's already in the navigation path, we should pop back to it instead of pushing it again
    • Only basic navigation works on iPad (1 level deep) because the navigation stack in split view detail can't capture links
  • Support iOS 16
    • I wanted to try new navigation destination features but it's an easy change
  • Support MacOS
  • Tap profile picture to show full screen
  • Add likes and retweets
  • Add share button

UI

uibreakdown uibreakdown2

iPad

iPhone

@landonr
swiftui project
853cdf0
@landonr
load tweets from json
84340a3
@landonr
show tweets in list
9252acb
@landonr
make cell for tweet
6281492
@landonr
highlight @mentions and links.
0f9726d 
open links in safari
@landonr
add test for text highlighting
6c26eed
@landonr
add tests for data service
d7a1119
@landonr
load profile picture and cache it
96db5df
@landonr
add tweet detail view
7aebfe2
@landonr
show tweet replies
121f96b
@landonr
clean up tweet replies
18cd855 
show users tweet if you tap on profile picture
@landonr
move replies into its own view
0c45adb
@landonr
show tweet threads
8acb2cf
@landonr
fix ui and preview
589e8a9
@landonr
localize strings
6ec764b
@landonr
fix user view preview
9db72c5
@landonr
format tweet date nicely
2850db1
@landonr
sort replies
ff29a11
@landonr
navigate through every view
1609003
@landonr
navigate to user if you tap tweet detail header
6943f1a
@landonr
open user when you tap on a mention
514a9c7
@landonr
fix reuse in tests
8d9a76a
@landonr
add default image for users. move images to enum
8b4af1c
@landonr
add ui tests
fcc47a2
@landonr
show thread in users view
de92c55
@landonr
update localization and readme
1783725
@landonr
rename tweet detail view model
9413ede
@landonr
add ui breakdown to readme
2f69df1
@landonr
Create ios.yml
dfd38ee
@landonr
format and add schedule to workflow
1835e7d
@landonr
try ci action again (#2)
24045dd 
* try ci action again

* just build because testing doesn't launch
@landonr
fix uitest for ipad
f3405a1
@landonr
Use background queue for api requests (#3)
3cd4631 
* put data from url methods in background thread

* add baseline launch speeds for ipad and iphone

* use background thread

* wait for an active image to download if instead of downloading it twice

* use nscache for in memory cache
@landonr
add uikit app (#4)
352b10b
far2an pushed a commit to far2an/OpenTweet that referenced this pull request Apr 20, 2024
opentable#2 Bonus - Added tweet cell animation on select and deselect
05a3e3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@landonr