Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer hostname determination to the post_config hook #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomhughes
Copy link
Member

This is an untested (compiled but not run) attempt to fix #41 by deferring the looking up of the hostname until the post_config hook.

@apmon
Copy link
Member

apmon commented Aug 13, 2013

It looks like it doesn't work.

scfg->configs->nelts appears to be 0 in the post_config hook and so the code is never executed.

@tomhughes
Copy link
Member Author

Is that just the first time it is called or is that still true the second time?

@apmon
Copy link
Member

apmon commented Aug 13, 2013

Unfortunately it seems to be true for both.

@tomhughes
Copy link
Member Author

Hmmm... Of course if there was actually any decent documentation for the apache module API then it might be easier to figure these things out...

@apmon
Copy link
Member

apmon commented Aug 13, 2013

There definitely seems to be a lack of documentation when exactly these hooks get called and how to fully use them

I think I might have tried a very similar thing in the past as well and it didn't work. Particularly I think it was getting the initial configuration Notice (you refer to in your other ticket) off the console and into the logs.

@apmon
Copy link
Member

apmon commented Aug 19, 2013

This doesn't seem to work for me. However, Tom has verified that it does work for him on both apache 2.2 and apache 2.4. Can anyone else verify if it works for them or not? Or might have an idea what is different? My guess is that it might have something to do about where things are defined. I.e. in the virtual server config or the general server, but I couldn't so far make it work to support this guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host name warning at startup/reload
2 participants