Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] 'SSL_CTX_set_cert_store' ownership of 'store' #24375

Closed
wants to merge 1 commit into from
Closed

[Docs] 'SSL_CTX_set_cert_store' ownership of 'store' #24375

wants to merge 1 commit into from

Conversation

ruslo
Copy link
Contributor

@ruslo ruslo commented May 12, 2024

Checklist
  • documentation is added or updated

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label May 12, 2024
t8m
t8m requested changes May 13, 2024
View reviewed changes
doc/man3/SSL_CTX_set_cert_store.pod Outdated Show resolved Hide resolved
@t8m t8m added branch: master Merge to master branch triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 labels May 13, 2024
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label May 13, 2024
@ruslo ruslo force-pushed the pr.set_cert_store_ownership branch from 4ee854f to 0b12e36 Compare May 13, 2024 12:23
@github-actions github-actions bot removed the severity: fips change The pull request changes FIPS provider sources label May 13, 2024
@mattcaswell
Copy link
Member

Please could you submit a CLA?

https://www.openssl.org/policies/cla.html

@ruslo
Copy link
Contributor Author

ruslo commented May 13, 2024

Please could you submit a CLA?

@mattcaswell I did it yesterday 👌 waiting for a reply

@ruslo
Copy link
Contributor Author

ruslo commented May 14, 2024

You have been added to our CLA database and should now be able to
contribute. If you have any open pull requests, you must close and reopen them to
remove the "needs CLA" tag.

@ruslo ruslo closed this May 14, 2024
@ruslo ruslo reopened this May 14, 2024
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label May 14, 2024
@t8m t8m added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member labels May 14, 2024
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label May 14, 2024
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 14, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 15, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented May 15, 2024

Merged to all the active branches. Thank you for your contribution.

@t8m t8m closed this May 15, 2024
openssl-machine pushed a commit that referenced this pull request May 15, 2024
@ruslo @t8m
[Docs] 'SSL_CTX_set_cert_store' ownership of 'store'
d2b2ebd 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24375)

(cherry picked from commit 987baef)
openssl-machine pushed a commit that referenced this pull request May 15, 2024
@ruslo @t8m
[Docs] 'SSL_CTX_set_cert_store' ownership of 'store'
af6f4aa 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24375)

(cherry picked from commit 987baef)
openssl-machine pushed a commit that referenced this pull request May 15, 2024
@ruslo @t8m
[Docs] 'SSL_CTX_set_cert_store' ownership of 'store'
987baef 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24375)
openssl-machine pushed a commit that referenced this pull request May 15, 2024
@ruslo @t8m
[Docs] 'SSL_CTX_set_cert_store' ownership of 'store'
2f3d849 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24375)

(cherry picked from commit 987baef)
openssl-machine pushed a commit that referenced this pull request May 15, 2024
@ruslo @t8m
[Docs] 'SSL_CTX_set_cert_store' ownership of 'store'
13f48c1 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24375)

(cherry picked from commit 987baef)
@ruslo ruslo deleted the pr.set_cert_store_ownership branch May 15, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ruslo @mattcaswell @openssl-machine @t8m