EC/DSA nonce generation fixes for 3.1 and 3.0 branches #24317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from openssl#24265) (cherry picked from commit d7d1bdc)
Also correct some BN_FLG_FIXED_TOP flag handling. Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from openssl#24265) (cherry picked from commit 2d285fa)
Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from openssl#24265) (cherry picked from commit 13b3ca5)
t8m
added
approval: review pending
And create a new BN_generate_dsa_nonce() that corrects the BIGNUM top. We do this to avoid leaking fixed top numbers via the public API. Also add a slight optimization in ossl_bn_gen_dsa_nonce_fixed_top() and make it LE/BE agnostic. Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from openssl#24265) (cherry picked from commit 9c85f6c)
Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from openssl#24265) (cherry picked from commit 8a1f654)
Otherwise following operations would bail out in bn_check_top(). Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from openssl#24265) (cherry picked from commit a380ae8)
t8m
force-pushed
the
fixed-nonce-generation-3.1
branch
from
3ffd54c
to
b514513
Compare
paulidale
approved these changes
May 5, 2024
paulidale
removed
the
approval: otc review pending
|
@nhorman ping for second review |
nhorman
approved these changes
May 6, 2024
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
@nhorman @paulidale please reconfirm - there was discrepancy in the prototypes of ossl_bn_is_word_fixed_top(). IMO no need to restart the timer. |
github-actions
bot
added
the
severity: fips change
|
approval holds, agreed, no need to restart the timer |
paulidale
approved these changes
May 8, 2024
openssl-machine
pushed a commit
that referenced
this pull request
May 9, 2024
And create a new BN_generate_dsa_nonce() that corrects the BIGNUM top. We do this to avoid leaking fixed top numbers via the public API. Also add a slight optimization in ossl_bn_gen_dsa_nonce_fixed_top() and make it LE/BE agnostic. Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Neil Horman <nhorman@openssl.org> (cherry picked from commit 9c85f6c) (Merged from #24317)
|
Merged to the 3.1 and 3.0 branches. Thank you for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
May 9, 2024
And create a new BN_generate_dsa_nonce() that corrects the BIGNUM top. We do this to avoid leaking fixed top numbers via the public API. Also add a slight optimization in ossl_bn_gen_dsa_nonce_fixed_top() and make it LE/BE agnostic. Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Neil Horman <nhorman@openssl.org> (cherry picked from commit 9c85f6c) (Merged from #24317) (cherry picked from commit fdc3efc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is backport of #24265 to 3.1 and 3.0 branches.