Proposed Windows installer #24277
Closed
Proposed Windows installer #24277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhorman
requested review from
Sashan,
levitte,
vdukhovni,
hlandau,
t8m,
mattcaswell and
t-j-h
quarckster
reviewed
Apr 27, 2024
make some improvements to the script. Realized we can group the installation sections into 64 and 32 bit groups for better organization. Also add in static libraries for users that want to statically link their own apps
quarckster
reviewed
Apr 29, 2024
| run: nmake /S | ||
| - name: build installer | ||
| working-directory: windows-installer | ||
| run: makensis.exe /DVERSION=${{ github.event.inputs.tag }} /DBUILD32=_build32 /DBUILD64=_build64 .\openssl.nsi |
There was a problem hiding this comment.
Why do you run the command directly instead of running windows-installer/Makefile?
There was a problem hiding this comment.
only because I created the ci workflow before I created the makefile, but I can fix that up
|
closing this - discussion from backlog refinement is that the installer should go into a separate repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of openssl/project#20 I've created this draft PR to propose a windows installer framework. The installer currently:
This PR expressly omits any offical building of the installer, as we need to determine how we would want to manage code signing certificates, as well as how we want to incorporate the building and releasing of the installer as part of our release process, but I think the installer itself is in pretty good shape. My proposal would be to incorporate this PR in 3.4 and target 3.5 for integrating a signed installer release into the 3.5 development cycle
Checklist