Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMP app: fix combination of -certout and -chainout with equal filename arg #24267

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DDvO
Copy link
Contributor

@DDvO DDvO commented Apr 25, 2024

When using the same filename argument with the cmp app options -certout and -chainout,
the file so far contains just the chain - the new cert is lost because it happens to get overwritten.
This is fixed here in a useful way without touching the API, namely by prepending the cert to its chain.
On this occasion also the documentation is improved.

Checklist
  • documentation is added or updated
  • tests are added or updated

@DDvO DDvO added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Merge to openssl-3.0 branch branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 labels Apr 25, 2024
@t8m
Copy link
Member

t8m commented Apr 26, 2024

Would it be hard to add a test?

@DDvO DDvO added the tests: present The PR has suitable tests present label Apr 26, 2024
@DDvO
Copy link
Contributor Author

DDvO commented Apr 26, 2024

Would it be hard to add a test?

I had already started thinking about that,
and meanwhile have added a test each on successfully producing and using the combined output file.

@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: review pending This pull request needs review by a committer branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 tests: present The PR has suitable tests present triaged: bug The issue/pr is/fixes a bug triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants