Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build (windows) with old MSVC compilers (was available before OpenSSL v3.3) #24262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Build (windows) with old MSVC compilers (was available before OpenSSL v3.3) #24262

wants to merge 1 commit into from

Conversation

yjh-styx
Copy link

@yjh-styx yjh-styx commented Apr 25, 2024 •
edited by tom-cosgrove-arm 

1. VC++ 2008 or earlier x86 compilers do not have inline implementation
    not only for InterlockedOr64, also for InterlockedAdd64 and
    InterlockedAnd64 (used in OSSL v3.3+)
2. VC++ 2008 or earlier x86 compilers not map _InterlockedOr to
    InterlockedOr
3. VC++ 2015 or earlier compilers not support 'inline' in C (nor C++) mode -
    only __inline

fix all this and remove legacy (non-trivial) variant of InterlockedOr64

@yjh-styx
Build (windows) with old MSVC compilers (was available before OSSL v…
b3c3435 
…3.3)

    1. VC++ 2008 or earlier x86 compilers do not have inline implementation
        not only for InterlockedOr64, also for InterlockedAdd64 and
        InterlockedAnd64 (used in OSSL v3.3+)
    2. VC++ 2008 or earlier x86 compilers not map _InterlockedOr to
        InterlockedOr
    3. VC++ 2015 or earlier compilers not support 'inline' in C (nor C++) mode -
        only __inline

    fix all this and remove legacy (non-trivial) variant of InterlockedOr64
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: feature The issue/pr requests/adds a feature tests: exempted The PR is exempt from requirements for testing labels Apr 25, 2024
@t8m t8m mentioned this pull request Apr 25, 2024
Closed
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Apr 25, 2024
@tom-cosgrove-arm tom-cosgrove-arm changed the title Build (windows) with old MSVC compilers (was available before OSS… Build (windows) with old MSVC compilers (was available before OSS… Apr 26, 2024
@tom-cosgrove-arm tom-cosgrove-arm changed the title Build (windows) with old MSVC compilers (was available before OSS… Build (windows) with old MSVC compilers (was available before OpenSSL v3.3) Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approval: otc review pending This pull request needs review by an OTC member approval: review pending This pull request needs review by a committer branch: master Merge to master branch severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yjh-styx @t8m