Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Typos #24233

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixing Typos #24233

wants to merge 4 commits into from

Conversation

nsp4746
Copy link

@nsp4746 nsp4746 commented Apr 22, 2024

Fixing some typos, i.e. consistency of spaces.

Checklist
  • documentation is added or updated
  • tests are added or updated

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Apr 22, 2024
@t8m
Copy link
Member

t8m commented Apr 22, 2024

Please drop the merge commit, these are not allowed. Also the commits can be squashed into one commit and the CLA: trivial annotation must be on a separate line in the git commit message body.

You can use git rebase -i; git push --force to edit your commits.

@t8m t8m added branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly labels Apr 22, 2024
bbbrumley
bbbrumley reviewed Apr 26, 2024
View reviewed changes
CHANGES.md
inband-signalling in the previous code (which relied on the
assumption that thread ID 0 is impossible).

*Bodo Moeller*
*Bodo Moeller*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nsp4746 looks like an accidental space insertion here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbbrumley bbbrumley bbbrumley left review comments

Assignees
No one assigned
Labels
branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' hold: cla required The contributor needs to submit a license agreement triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nsp4746 @t8m @bbbrumley @openssl-machine