Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FYI 3.3 backport] fips: enforce minimum MAC key length of 112 bits #24225

Closed
wants to merge 4 commits into from
Closed

[FYI 3.3 backport] fips: enforce minimum MAC key length of 112 bits #24225

wants to merge 4 commits into from

Commits on Apr 22, 2024

  1. Use RFC 5869 test case for HKDF self-test 

    According to NIST SP 800-131Ar2 section 8, the length of the
key-derivation key shall be at least 112 bits.

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#23833)

(cherry picked from commit 23fd48d)
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@surgut.co.uk>
    @0140454 @xnox
    0140454 authored and xnox committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    d04a1fa View commit details
    Browse the repository at this point in the history

  2. hkdf: when HMAC key is all zeros, still set a valid key length 

    By itself, this is no change in any computation. However, this will
unlock enforcing minimum key lengths for NIST and FIPS 140-3
requirements.

Also reading RFC8448 and RFC5869, this seems to be strictly correct
too.

Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@surgut.co.uk>
(cherry picked from commit d657b03)
    @xnox
    xnox committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9c8b1c3 View commit details
    Browse the repository at this point in the history

  3. fips: enforce minimum MAC key length of 112 bits 

    Most regulations require 112 bits. Post 2030 transition to 128 bits is
likely. Implement security check to validate minimum MAC key length.

For FIPS, set it to 112 bits. This is inline with key sizes
recommendations in https://doi.org/10.6028/NIST.SP.800-131Ar2.

Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@surgut.co.uk>
    @xnox
    xnox committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e36f71e View commit details
    Browse the repository at this point in the history

  4. WIP: skip all failing test cases 

    Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@surgut.co.uk>
    @xnox
    xnox committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    c885f7b View commit details
    Browse the repository at this point in the history