Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSL_STORE: Windows: use system certificates storage as default store #24218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yjh-styx
Copy link

@yjh-styx yjh-styx commented Apr 20, 2024

don't change X509_get_default_cert_dir - it used as default directory also (by_dir.c:91)

crypto/x509/by_store.c Outdated Show resolved Hide resolved
@t8m
Copy link
Member

t8m commented Apr 22, 2024

Please do not add merge commits. Instead if there are conflicts, please rebase and force-push.

@hlandau
Copy link
Member

hlandau commented Apr 29, 2024

I don't think this is adequate. See #21190 for the history. This was already done and had to be reverted.

@t8m t8m added resolved: wont fix The issue has been confirmed but won't be fixed triaged: feature The issue/pr requests/adds a feature labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolved: wont fix The issue has been confirmed but won't be fixed triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants