New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BN_add.pod documentation so they are consistent with their header declarations. Fixes issue #19521 #24215
base: master
Are you sure you want to change the base?
Conversation
…der declarations CLA: trivial
I created a PR to meet the requirements for the SWE assignment for CSEC 659. @bbbrumley please review when you get the chance. Thank you! |
Looks good to me :) Thank you, @JulieDzeze1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: it looks like these const
s predate even 1.1.1 in the headers!
Thanks for your contribution @JulieDzeze1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @JulieDzeze1 I was too hasty in my review: we would need you to rebase your commit on top of latest master
, as we do not allow Merge commits.
Can you handle this or do you need furhter guidance?
I agree with CLA: trivial |
This would fix #19521 but for some reason the GitHub UI does not let me link the issue with this PR or viceversa. |
Hi, I've attempted to rebase my commit but this is a little complicated since this is a forked repository from the main project. How should I approach it? |
You do not even need to rebase against fresh master branch. Just remove the merge commit with |
Update BN_add.pod documentation so they are consistent with their header declarations. Fixes issue #19521 on OpenSSL's master branch.