Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BN_add.pod documentation so they are consistent with their header declarations. Fixes issue #19521 #24215

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JulieDzeze1
Copy link

@JulieDzeze1 JulieDzeze1 commented Apr 19, 2024

Update BN_add.pod documentation so they are consistent with their header declarations. Fixes issue #19521 on OpenSSL's master branch.

@JulieDzeze1
Copy link
Author

I created a PR to meet the requirements for the SWE assignment for CSEC 659. @bbbrumley please review when you get the chance. Thank you!

@bbbrumley
Copy link
Contributor

Looks good to me :) Thank you, @JulieDzeze1

@romen romen added triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 branch: master Merge to master branch labels Apr 20, 2024
Copy link
Member

@romen romen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: it looks like these consts predate even 1.1.1 in the headers!

Thanks for your contribution @JulieDzeze1

@romen romen added the approval: review pending This pull request needs review by a committer label Apr 20, 2024
Copy link
Member

@romen romen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @JulieDzeze1 I was too hasty in my review: we would need you to rebase your commit on top of latest master, as we do not allow Merge commits.

Can you handle this or do you need furhter guidance?

@romen romen added the cla: trivial One of the commits is marked as 'CLA: trivial' label Apr 20, 2024
@romen
Copy link
Member

romen commented Apr 20, 2024

I agree with CLA: trivial

@romen
Copy link
Member

romen commented Apr 20, 2024

This would fix #19521 but for some reason the GitHub UI does not let me link the issue with this PR or viceversa.

@t8m t8m added the tests: exempted The PR is exempt from requirements for testing label Apr 22, 2024
@JulieDzeze1
Copy link
Author

Sorry @JulieDzeze1 I was too hasty in my review: we would need you to rebase your commit on top of latest master, as we do not allow Merge commits.

Can you handle this or do you need furhter guidance?

Hi, I've attempted to rebase my commit but this is a little complicated since this is a forked repository from the main project. How should I approach it?

@t8m
Copy link
Member

t8m commented Apr 23, 2024

Hi, I've attempted to rebase my commit but this is a little complicated since this is a forked repository from the main project. How should I approach it?

You do not even need to rebase against fresh master branch. Just remove the merge commit with git reset --hard HEAD~ ; git push --force.

@t8m t8m reopened this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: review pending This pull request needs review by a committer branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 cla: trivial One of the commits is marked as 'CLA: trivial' tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants