Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fips: remove P-192 #24195

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fips: remove P-192 #24195

wants to merge 2 commits into from

Conversation

xnox
Copy link
Contributor

@xnox xnox commented Apr 18, 2024

In recent NIST standards P-192 now has legacy status for verification only, remove it from FIPS module.

Note, I don't believe it ever was popular. Thus I'm not sure it is needed to support "verification-only" mode of P-192 in the FIPS module.

Related: 24193

Checklist
  • documentation is added or updated
  • tests are added or updated

prime192v1 (P-192) is allowed for signature verification and key pair
verification but not for signature generation.

Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@surgut.co.uk>
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@surgut.co.uk>
@t8m t8m added the triaged: feature The issue/pr requests/adds a feature label Apr 18, 2024
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Apr 18, 2024
@t8m t8m added hold: need otc decision The OTC needs to make a decision branch: master Merge to master branch labels Apr 18, 2024
@paulidale
Copy link
Contributor

I don't think we can remove this outright.
It's pretty much guaranteed that someone will be using it 😢

@xnox
Copy link
Contributor Author

xnox commented Apr 19, 2024

I don't think we can remove this outright.
It's pretty much guaranteed that someone will be using it 😢

It will still be available in regular builds, just not in FIPS provider.

The other approach is to patch security checks to allow it for just verification.

But that still is the same net result that somebody is using it and will be broken. Or add indicators.... But that's also questionable, as most software doesn't actually check for those.

I mean. Transition to 128bit requirements from 2030 will be fun.

@paulidale
Copy link
Contributor

The other approach is to patch security checks to allow it for just verification.

Yes to this. But we also require a bypass mechanism that uses explicit indicators.
It's still being thrashed out.

@t8m
Copy link
Member

t8m commented Apr 23, 2024

OTC: This cannot be a hard removal. It will need an indicator implemented as in the indicators requirements PR.

Indicator requirements PR: #23609

@t8m t8m removed the hold: need otc decision The OTC needs to make a decision label Apr 23, 2024
@xnox
Copy link
Contributor Author

xnox commented Apr 23, 2024

OTC: This cannot be a hard removal. It will need an indicator implemented as in the indicators requirements PR.

Indicator requirements PR: #23609

Ack. I'm not interested to implement an indicator though. Would a compile time option be acceptable with an implicit indicator? I.e. ./Configure no-p192 ?

@xnox xnox marked this pull request as draft April 23, 2024 13:18
@t8m
Copy link
Member

t8m commented Apr 23, 2024

OTC: This cannot be a hard removal. It will need an indicator implemented as in the indicators requirements PR.
Indicator requirements PR: #23609

Ack. I'm not interested to implement an indicator though. Would a compile time option be acceptable with an implicit indicator? I.e. ./Configure no-p192 ?

I think it would have to be something more general than just for this particular curve. Also it should have fips in the name as it would be really awkward to remove just this curve. Or... maybe what about no-weak-ec-curves ? Then it could be a removal of all weak (less than 255) bit curves from both fips and default providers.

@xnox
Copy link
Contributor Author

xnox commented Apr 23, 2024

OTC: This cannot be a hard removal. It will need an indicator implemented as in the indicators requirements PR.
Indicator requirements PR: #23609

Ack. I'm not interested to implement an indicator though. Would a compile time option be acceptable with an implicit indicator? I.e. ./Configure no-p192 ?

I think it would have to be something more general than just for this particular curve. Also it should have fips in the name as it would be really awkward to remove just this curve. Or... maybe what about no-weak-ec-curves ? Then it could be a removal of all weak (less than 255) bit curves from both fips and default providers.

ACK.

We will sort of have an impeding 128bit transition too. Which will sort of be either raising security level; or checking all the security bits. Because that would allow to drop SHA1 (haha) SHA2-224 (easy) SHA3-224 (trivial) P-192 and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch: master Merge to master branch severity: fips change The pull request changes FIPS provider sources triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants