Add Support for Huron Digital Pathology Scanner Generated Images #398
Conversation
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
|
@101x4 It looks like there are two problems with your signoff lines: the signoffs need to exactly match the name and email address of the commit author, and the first two commits in the PR have not been signed off. You'll need to edit your existing commit messages with |
|
For #260. |
|
@101x4 Use |
101x4
force-pushed
the
main
branch
2 times, most recently
from
94de38e
to
0caebe7
Compare
|
I think the problem is that Openslide has changed a lot and our modification for HDP several years ago is no longer effective :( |
Signed-off-by: Bjiao <bjiao@hurondigitalpathology.com> update Makefile Signed-off-by: Bjiao <bjiao@hurondigitalpathology.com>
|
@bgilbert Can you help with this error: "Fetching zlib..." failed with "Failed: ${wget} -P tar "$url" (line 255)"? |
|
It seems the previous release of zlib has been removed from its website for some reason. openslide/openslide-bin#54 should fix CI. |
Signed-off-by: Bjiao <bjiao@hurondigitalpathology.com>
|
@bgilbert Fetching openslide-java also failed with "Failed: ${wget} -P tar "$url" (line 255)". And how can I rerun the checks? |
|
There should be a menu entry in the triple-dots menu after you click "Details". I'm not sure if you have access to it though. I've restarted the check. |
|
Thanks for the PR! Could you submit some sample files that we can include in our sample library and in automated test cases? There's a question at the bottom of the form asking if we can redistribute the samples; we'd need that permission in order to use the slides for these purposes. |
|
Images uploaded, and please ignore the zip file. Thanks. |
- Added support for Huron generated images. - Based on the work in openslide#398 Signed-off-by: Kyle Delaney <kdelaney@hurondigitalpathology.com>
This version adds supports for the huron scanner generated images.
Please close the former PR (#286), which is created by former employee from Huron, thanks.