Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Leica GT450 scanner associated images #343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nirbenor-ibex
Copy link

Solves: #297

@fiendish
Copy link

fiendish commented Oct 17, 2021

I'm curious about the "fallback" comment. Do you have older files where the subfiletype tifftag has not always been the correct way to detect this? That message from Leica says it's true for not just gt450, and I haven't found any svs files where it's not the case. So far I've been suspecting that the format spec did not actually change and that the original detection mechanism here was someone just winging it, but if you know of a machine that generates files without those tifftags that can be shared, I'd love to add such a file to my test set.

@nirbenor-ibex
Copy link
Author

nirbenor-ibex commented Oct 17, 2021

I'm curious about the "fallback" comment. Do you have older files where the subfiletype tifftag has not always been the correct way to detect this? That message from Leica says it's true for not just gt450, and I haven't found any svs files where it's not the case. So far I've been suspecting that the format spec did not actually change and that the original detection mechanism here was someone just winging it, but if you know of a machine that generates files without those tifftags that can be shared, I'd love to add such a file to my test set.

I don't have such files, so you are correct that the comment was a bit misleading, I changed how its phrased.
I chose to fallback to the previous detection mechanism as a safety measure because I couldn't find any formal spec to follow..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants