Support for Tile Joint Left Direction

[ChrisSmith96]

I have access to some .bif files which have the TileJointInfo direction attribute set to LEFT rather than RIGHT. Openslide doesn’t currently support such files so I have made some simple changes so they can be opened. I have done some testing opening .bif files containing the LEFT join direction and the resulting image is almost exactly the same when processed as if it had the direction attribute set to RIGHT. Please could you consider merging this change into openslide to support files with this attribute!

[agoode]

Thanks for this contribution.

I want to make sure we are supporting this variant properly.

• What are the differences between LEFT and RIGHT?
• Should we add an OpenSlide property to expose this?

[ChrisSmith96]

I’m not sure that I understand the differences between the two values, but all images that I have access to from a VENTANA DP 200 scanner have this attribute set to LEFT and not to RIGHT.

With regards to adding an OpenSlide property, I don’t think that this is a generic property seen in all files. It appears to be specific to BIF files.

[jrshoare]

This PR looks as though it might solve issue #234. Any idea when it might get merged in to the base branch?

[p829911]

I had the same problem with the ventana.bif file, so I compiled myself and used openslide.
May I ask you to merge this pull request?

[jimtalksdata]

The current gen mid-capacity DP200 scanner produces these sorts of files (when set to BIF format). https://diagnostics.roche.com/global/en/products/instruments/ventana-dp-200-slide-scanner-research.html

Agree on merging this pull request. Only changes the appropriate file and one conditional, so I don't see any backwards or forwards compatibility issues.

[sbengali]

Is there any update to the python package that fixes this issue? I am trying to read BIF files and running into this problem. Thanks.

[itachi1232gg]

@ChrisSmith96 @jimtalksdata hello sir, this small change can help open Roche bif image, but if you watch the bif image carefully, there is something wrong with the tile offset. joint->offset_x *= -1;

[suk-kim]

Is this problem not solved yet?

The left problem has been solved, but the problem of the image not opening properly is not solved.

[bgilbert]

@ValentinFrancois The BIF specification that you referenced appears to be covered by these license terms, which right away in the first paragraph contain a field-of-use restriction (the definition of "Purpose" and the limitation to certain scanner models) which is incompatible with OpenSlide's LGPL license. As a result, we cannot accept any code into OpenSlide that has been created with the aid of that specification document. I've marked your comment as "off-topic" so GitHub's web interface will hide it by default.

[ValentinFrancois]

@bgilbert Sorry for that, the PDF is referenced in Google so one can access it outside of the download form without being aware of the license. Thanks for your alertness.