New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Dynamic variants in Component Readiness #1628
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -472,6 +477,29 @@ func (c *componentReportGenerator) getJobRunTestStatusFromBigQuery() (apitype.Co | |||
} | |||
|
|||
func (c *componentReportGenerator) getCommonTestStatusQuery() (string, string, []bigquery.QueryParameter) { | |||
|
|||
// Simulate a list of varaints that were requested, this would be specified in the API request / UI in the real world... | |||
variants := []string{"Network", "Upgrade", "Architecture", "Platform"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
groupBy query param becomes the above array
Additional includeVariant query param comes in with Installer:hypershift for example. When includes are specified we inject a join and a where, but not a groupby for that variant name.
@dgoodwin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a PoC to explore how we could get component readiness working with dynamic variants instead of a fixed set as we do today.
The general approach outlined thus far: