Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT-1615: Create api to use the new variant registry #1616

Merged
merged 1 commit into from May 6, 2024
Merged

TRT-1615: Create api to use the new variant registry #1616

merged 1 commit into from May 6, 2024

Conversation

xueqzhan
Copy link
Contributor

@xueqzhan xueqzhan commented Apr 17, 2024 •
edited

New API "/api/jobs/variants".

Example output:

{
  "variants": {
    "Aggregation": [
      "aggregated",
      "none"
    ],
    "Architecture": [
      "amd64",
      "arm64",
      "heterogeneous",
      "ppc64le",
      "s390x"
    ],
    "FeatureSet": [
      "default",
      "techpreview"
    ],
    "FromRelease": [
      "0.0",
      "0.1",
      "0.2",
      "0.22",
      "0.23",
      "0.24",
      "0.25",
      "0.26",
      "1.0",
      "1.1",
      "1.2",
      "1.3",
      "1.4",
      "1.5",
      "1.6",
      "1.7",
      "1.8",
      "1.9",
      "1.10",
      "1.11",
      "1.12",
      "1.13",
      "1.14",
      "1.15",
      "1.16",
      "1.17",
      "1.18",
      "1.19",
      "1.20",
      "1.21",
      "1.22",
      "1.23",
      "1.24",
      "1.25",
      "1.26",
      "1.27",
      "1.28",
      "1.29",
      "1.30",
      "1.31",
      "1.32",
      "1.52",
      "1.54",
      "1.55",
      "1.58",
      "1.64",
      "1.70",
      "2.2",
      "2.3",
      "2.4",
      "2.5",
      "2.6",
      "2.7",
      "2.8",
      "2.9",
      "2.10",
      "3.11",
      "4.1",
      "4.2",
      "4.3",
      "4.4",
      "4.5",
      "4.6",
      "4.7",
      "4.8",
      "4.9",
      "4.10",
      "4.11",
      "4.12",
      "4.13",
      "4.14",
      "4.15",
      "4.16",
      "4.17",
      "5.0",
      "5.1",
      "5.2",
      "5.3",
      "5.4",
      "5.5",
      "5.6",
      "5.7",
      "5.8",
      "5.9"
    ],
    "FromReleaseMajor": [
      "0",
      "1",
      "2",
      "3",
      "4",
      "5"
    ],
    "FromReleaseMinor": [
      "0",
      "1",
      "2",
      "3",
      "4",
      "5",
      "6",
      "7",
      "8",
      "9",
      "10",
      "11",
      "12",
      "13",
      "14",
      "15",
      "16",
      "17",
      "18",
      "19",
      "20",
      "21",
      "22",
      "23",
      "24",
      "25",
      "26",
      "27",
      "28",
      "29",
      "30",
      "31",
      "32",
      "52",
      "54",
      "55",
      "58",
      "64",
      "70"
    ],
    "Installer": [
      "assisted",
      "hypershift",
      "ipi",
      "upi"
    ],
    "Network": [
      "ovn",
      "sdn"
    ],
    "NetworkAccess": [
      "default",
      "proxy"
    ],
    "NetworkStack": [
      "IPv4",
      "IPv6",
      "dual",
      "ipv4",
      "ipv6"
    ],
    "Owner": [
      "eng",
      "osd"
    ],
    "Platform": [
      "alibaba",
      "aws",
      "azure",
      "gcp",
      "libvirt",
      "metal",
      "openstack",
      "ovirt",
      "vsphere"
    ],
    "Release": [
      "0.0",
      "0.1",
      "0.2",
      "0.22",
      "0.23",
      "0.24",
      "0.25",
      "0.26",
      "1.0",
      "1.1",
      "1.2",
      "1.3",
      "1.4",
      "1.5",
      "1.6",
      "1.7",
      "1.8",
      "1.9",
      "1.10",
      "1.11",
      "1.12",
      "1.13",
      "1.14",
      "1.19",
      "1.20",
      "1.21",
      "1.22",
      "1.23",
      "1.24",
      "1.25",
      "1.26",
      "1.27",
      "1.28",
      "1.29",
      "1.30",
      "1.31",
      "1.32",
      "1.52",
      "1.54",
      "1.55",
      "1.58",
      "1.64",
      "1.70",
      "2.2",
      "2.3",
      "2.4",
      "2.5",
      "2.6",
      "2.7",
      "2.8",
      "2.9",
      "2.10",
      "3.11",
      "4.1",
      "4.2",
      "4.3",
      "4.4",
      "4.5",
      "4.6",
      "4.7",
      "4.8",
      "4.9",
      "4.10",
      "4.11",
      "4.12",
      "4.13",
      "4.14",
      "4.15",
      "4.16",
      "4.17",
      "5.0",
      "5.1",
      "5.2",
      "5.3",
      "5.4",
      "5.5",
      "5.6",
      "5.7",
      "5.8",
      "5.9"
    ],
    "ReleaseMajor": [
      "0",
      "1",
      "2",
      "3",
      "4",
      "5"
    ],
    "ReleaseMinor": [
      "0",
      "1",
      "2",
      "3",
      "4",
      "5",
      "6",
      "7",
      "8",
      "9",
      "10",
      "11",
      "12",
      "13",
      "14",
      "15",
      "16",
      "17",
      "19",
      "20",
      "21",
      "22",
      "23",
      "24",
      "25",
      "26",
      "27",
      "28",
      "29",
      "30",
      "31",
      "32",
      "52",
      "54",
      "55",
      "58",
      "64",
      "70"
    ],
    "Scheduler": [
      "default",
      "realtime"
    ],
    "SecurityMode": [
      "default",
      "fips"
    ],
    "Suite": [
      "etcd-scaling",
      "serial",
      "unknown"
    ],
    "Topology": [
      "compact",
      "external",
      "ha",
      "microshift",
      "single"
    ],
    "Upgrade": [
      "micro",
      "minor",
      "none"
    ]
  }
}

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@xueqzhan xueqzhan changed the title Create api to use the new variant registry TRT-1615: Create api to use the new variant registry Apr 23, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024 •
edited by openshift-ci bot

@xueqzhan: This pull request references TRT-1615 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

New API "/api/jobs/variants".

Example output:

{
 "variants": {
   "Aggregation": [
     "aggregated",
     "none"
   ],
   "Architecture": [
     "amd64",
     "arm64",
     "heterogeneous",
     "ppc64le",
     "s390x"
   ],
   "FeatureSet": [
     "default",
     "techpreview"
   ],
   "FromRelease": [
     "0.0",
     "0.1",
     "0.2",
     "0.22",
     "0.23",
     "0.24",
     "0.25",
     "0.26",
     "1.0",
     "1.1",
     "1.2",
     "1.3",
     "1.4",
     "1.5",
     "1.6",
     "1.7",
     "1.8",
     "1.9",
     "1.10",
     "1.11",
     "1.12",
     "1.13",
     "1.14",
     "1.15",
     "1.16",
     "1.17",
     "1.18",
     "1.19",
     "1.20",
     "1.21",
     "1.22",
     "1.23",
     "1.24",
     "1.25",
     "1.26",
     "1.27",
     "1.28",
     "1.29",
     "1.30",
     "1.31",
     "1.32",
     "1.52",
     "1.54",
     "1.55",
     "1.58",
     "1.64",
     "1.70",
     "2.2",
     "2.3",
     "2.4",
     "2.5",
     "2.6",
     "2.7",
     "2.8",
     "2.9",
     "2.10",
     "3.11",
     "4.1",
     "4.2",
     "4.3",
     "4.4",
     "4.5",
     "4.6",
     "4.7",
     "4.8",
     "4.9",
     "4.10",
     "4.11",
     "4.12",
     "4.13",
     "4.14",
     "4.15",
     "4.16",
     "4.17",
     "5.0",
     "5.1",
     "5.2",
     "5.3",
     "5.4",
     "5.5",
     "5.6",
     "5.7",
     "5.8",
     "5.9"
   ],
   "FromReleaseMajor": [
     "0",
     "1",
     "2",
     "3",
     "4",
     "5"
   ],
   "FromReleaseMinor": [
     "0",
     "1",
     "2",
     "3",
     "4",
     "5",
     "6",
     "7",
     "8",
     "9",
     "10",
     "11",
     "12",
     "13",
     "14",
     "15",
     "16",
     "17",
     "18",
     "19",
     "20",
     "21",
     "22",
     "23",
     "24",
     "25",
     "26",
     "27",
     "28",
     "29",
     "30",
     "31",
     "32",
     "52",
     "54",
     "55",
     "58",
     "64",
     "70"
   ],
   "Installer": [
     "assisted",
     "hypershift",
     "ipi",
     "upi"
   ],
   "Network": [
     "ovn",
     "sdn"
   ],
   "NetworkAccess": [
     "default",
     "proxy"
   ],
   "NetworkStack": [
     "IPv4",
     "IPv6",
     "dual",
     "ipv4",
     "ipv6"
   ],
   "Owner": [
     "eng",
     "osd"
   ],
   "Platform": [
     "alibaba",
     "aws",
     "azure",
     "gcp",
     "libvirt",
     "metal",
     "openstack",
     "ovirt",
     "vsphere"
   ],
   "Release": [
     "0.0",
     "0.1",
     "0.2",
     "0.22",
     "0.23",
     "0.24",
     "0.25",
     "0.26",
     "1.0",
     "1.1",
     "1.2",
     "1.3",
     "1.4",
     "1.5",
     "1.6",
     "1.7",
     "1.8",
     "1.9",
     "1.10",
     "1.11",
     "1.12",
     "1.13",
     "1.14",
     "1.19",
     "1.20",
     "1.21",
     "1.22",
     "1.23",
     "1.24",
     "1.25",
     "1.26",
     "1.27",
     "1.28",
     "1.29",
     "1.30",
     "1.31",
     "1.32",
     "1.52",
     "1.54",
     "1.55",
     "1.58",
     "1.64",
     "1.70",
     "2.2",
     "2.3",
     "2.4",
     "2.5",
     "2.6",
     "2.7",
     "2.8",
     "2.9",
     "2.10",
     "3.11",
     "4.1",
     "4.2",
     "4.3",
     "4.4",
     "4.5",
     "4.6",
     "4.7",
     "4.8",
     "4.9",
     "4.10",
     "4.11",
     "4.12",
     "4.13",
     "4.14",
     "4.15",
     "4.16",
     "4.17",
     "5.0",
     "5.1",
     "5.2",
     "5.3",
     "5.4",
     "5.5",
     "5.6",
     "5.7",
     "5.8",
     "5.9"
   ],
   "ReleaseMajor": [
     "0",
     "1",
     "2",
     "3",
     "4",
     "5"
   ],
   "ReleaseMinor": [
     "0",
     "1",
     "2",
     "3",
     "4",
     "5",
     "6",
     "7",
     "8",
     "9",
     "10",
     "11",
     "12",
     "13",
     "14",
     "15",
     "16",
     "17",
     "19",
     "20",
     "21",
     "22",
     "23",
     "24",
     "25",
     "26",
     "27",
     "28",
     "29",
     "30",
     "31",
     "32",
     "52",
     "54",
     "55",
     "58",
     "64",
     "70"
   ],
   "Scheduler": [
     "default",
     "realtime"
   ],
   "SecurityMode": [
     "default",
     "fips"
   ],
   "Suite": [
     "etcd-scaling",
     "serial",
     "unknown"
   ],
   "Topology": [
     "compact",
     "external",
     "ha",
     "microshift",
     "single"
   ],
   "Upgrade": [
     "micro",
     "minor",
     "none"
   ]
 }
}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xueqzhan
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024 •
edited by openshift-ci bot

@xueqzhan: This pull request references TRT-1615 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dgoodwin
dgoodwin reviewed May 3, 2024
View reviewed changes
pkg/sippyserver/server.go
Description: "Reports all job variants defined in BigQuery",
Capabilities: []string{ComponentReadinessCapability},
HandlerFunc: s.jsonJobVariantsFromBigQuery,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like all other apis under /api/jobs/ are specific to a job. This new one is not. Maybe not worth worrying about, but we could do /api/job_variants/ or /api/variants to designate that we're operating on a different resource/?

We could also end up colliding with our wish to have an API to fetch the variants for a specific job. Probably should try to find another path to move it to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/api/variants is already taken. :) Let me do /api/job_variants/ for now. We need to clean up on those old variants API later.

pkg/api/component_report.go
}
}
return false
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive sorting.

@dgoodwin
Copy link
Contributor

dgoodwin commented May 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 6, 2024

@xueqzhan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dgoodwin
Copy link
Contributor

dgoodwin commented May 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b4e0dfb into openshift:master May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgoodwin dgoodwin dgoodwin left review comments

@deads2k deads2k Awaiting requested review from deads2k

@deepsm007 deepsm007 Awaiting requested review from deepsm007

Assignees

@dgoodwin dgoodwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xueqzhan @openshift-ci-robot @dgoodwin