New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-5479 | ci: Refactor the day 1 creation - supported subnets,proxy,KMS key,security group,auditlog,z|y-1 version #1969
Conversation
xueli181114
commented
Apr 26, 2024
•
edited
edited
09a80d7
to
9fefed9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1969 +/- ##
==========================================
+ Coverage 23.52% 23.71% +0.18%
==========================================
Files 137 138 +1
Lines 21284 21558 +274
==========================================
+ Hits 5008 5113 +105
- Misses 15905 16034 +129
- Partials 371 411 +40 ☔ View full report in Codecov by Sentry. |
/assign @ciaranRoche @hunterkepley |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small NP but other than that LGTM
…KMS key,security group,audit log, version y,z-1 Fix the comment
/retest |
/lgtm |
/lgtm |
/approved |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciaranRoche, xueli181114, yasun1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xueli181114: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |