OCM-7415 | feat: Ensure account roles have expected attached policies

[marcolan018]

https://issues.redhat.com/browse/OCM-7415
https://issues.redhat.com/browse/OCM-1752

Signed-off-by: marcolan018 llan@redhat.com

[codecov]

Codecov Report

Attention: Patch coverage is 25.44379% with 126 lines in your changes are missing coverage. Please review.

Project coverage is 24.32%. Comparing base (da3615e) to head (a63f63d).
Report is 21 commits behind head on master.

Files	Patch %	Lines
cmd/upgrade/roles/cmd.go	0.00%	69 Missing ⚠️
pkg/aws/policies.go	0.00%	23 Missing ⚠️
pkg/aws/mock_client.go	0.00%	18 Missing ⚠️
pkg/ocm/rolepolicybinding.go	0.00%	10 Missing ⚠️
pkg/helper/rolepolicybindings/helpers.go	87.75%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1966      +/-   ##
==========================================
+ Coverage   24.02%   24.32%   +0.30%     
==========================================
  Files         138      140       +2     
  Lines       21425    21531     +106     
==========================================
+ Hits         5147     5238      +91     
- Misses      15876    15888      +12     
- Partials      402      405       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[davidleerh]

small np in error messages but overall looks good to me.
Thank you for putting great effort and thought into this; considering possible edge case scenarios!

[ciaranRoche]

Small Nitpicks but looks good otherwise

[marcolan018]

/retest

[ciaranRoche]

LGTM nice work

[davidleerh]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, davidleerh, marcolan018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ciaranRoche,davidleerh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davidleerh]

/retest

[marcolan018]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 0f7d409 and 2 for PR HEAD a63f63d in total

[davidleerh]

/retest

[openshift-ci]

@marcolan018: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.