Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7614 | fix: Get the merged commit but not the pull request commit #1965

Merged
merged 1 commit into from Apr 29, 2024

Conversation

yasun1
Copy link
Contributor

@yasun1 yasun1 commented Apr 25, 2024

The output is like:
The lastest commit updates the test: 11111|11112|21111|21112

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.51%. Comparing base (465a422) to head (ac79e7e).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1965      +/-   ##
==========================================
+ Coverage   23.22%   23.51%   +0.29%     
==========================================
  Files         136      137       +1     
  Lines       21160    22310    +1150     
==========================================
+ Hits         4914     5247     +333     
- Misses      15879    16653     +774     
- Partials      367      410      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yasun1 yasun1 changed the title [WIP] OCM-7614 | fix: Get the merged commit but not the pull request commit OCM-7614 | fix: Get the merged commit but not the pull request commit Apr 25, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024
@yasun1 yasun1 force-pushed the pre-submit branch 3 times, most recently from 1b27100 to bbe7aa4 Compare April 25, 2024 09:33
@yasun1
Copy link
Contributor Author

yasun1 commented Apr 25, 2024

@ciaranRoche @hunterkepley Please help review. Thanks.

Copy link
Member

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, yasun1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

@yasun1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b2ab832 into openshift:master Apr 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants