Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7256 | feat: Move non-cmd funcs to pkg, split, test #1964

Merged
merged 2 commits into from May 7, 2024

Conversation

hunterkepley
Copy link
Contributor

OCM-7256 Has the following definition of done:

Functions have been moved to new machine pool package
Functions test coverage is at least 70%

The 70% test coverage may not be there yet, as one function requires a runner to be tested. This will be done ALONG WITH the rework in the next ticket: https://issues.redhat.com/browse/OCM-7257

This MR splits the list function up where possible, along with combining machine and node pool funcs into a single function as they have quite a bit of shared code and there's no reason to separate.

@hunterkepley
Copy link
Contributor Author

/test coverage

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 59.37500% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 24.23%. Comparing base (59e94e8) to head (640be58).
Report is 66 commits behind head on master.

Files Patch % Lines
pkg/machinepool/machinepool.go 59.37% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1964      +/-   ##
==========================================
+ Coverage   23.22%   24.23%   +1.01%     
==========================================
  Files         136      138       +2     
  Lines       21160    21859     +699     
==========================================
+ Hits         4914     5298     +384     
- Misses      15879    16160     +281     
- Partials      367      401      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/machinepool/machinepool.go Outdated Show resolved Hide resolved
pkg/machinepool/machinepool.go Outdated Show resolved Hide resolved
pkg/machinepool/machinepool.go Outdated Show resolved Hide resolved
cmd/list/machinepool/cmd.go Outdated Show resolved Hide resolved
pkg/machinepool/machinepool.go Outdated Show resolved Hide resolved
@chenz4027
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
pkg/machinepool/machinepool.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
Copy link
Member

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, ciaranRoche, hunterkepley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
Copy link
Contributor

openshift-ci bot commented May 7, 2024

@hunterkepley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 465c0cd into openshift:master May 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants