New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-7256 | feat: Move non-cmd funcs to pkg, split, test #1964
Conversation
/test coverage |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1964 +/- ##
==========================================
+ Coverage 23.22% 24.23% +1.01%
==========================================
Files 136 138 +2
Lines 21160 21859 +699
==========================================
+ Hits 4914 5298 +384
- Misses 15879 16160 +281
- Partials 367 401 +34 ☔ View full report in Codecov by Sentry. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenz4027, ciaranRoche, hunterkepley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hunterkepley: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
OCM-7256 Has the following definition of done:
The 70% test coverage may not be there yet, as one function requires a runner to be tested. This will be done ALONG WITH the rework in the next ticket: https://issues.redhat.com/browse/OCM-7257
This MR splits the list function up where possible, along with combining machine and node pool funcs into a single function as they have quite a bit of shared code and there's no reason to separate.