New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-7573 | fix: ensure version option args are initialised #1960
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1960 +/- ##
==========================================
+ Coverage 23.54% 23.56% +0.02%
==========================================
Files 138 138
Lines 21331 21333 +2
==========================================
+ Hits 5022 5027 +5
+ Misses 15935 15931 -4
- Partials 374 375 +1 ☔ View full report in Codecov by Sentry. |
/cherrypick release_1.2.39 |
@ciaranRoche: once the present PR merges, I will cherry-pick it on top of release_1.2.39 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciaranRoche, robpblake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ciaranRoche: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@ciaranRoche: new pull request created: #1978 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
WHAT
When calling BindAndValidate the option args were not initialized, this changes ensures the args are initialized on
NewRosaVersionOptions
This change also sets the checkVersion to debug in the case of any failures while trying to check the CLI version. Only when we successfully validate the version will we warn the user if its out of date.
JIRA - https://issues.redhat.com/browse/OCM-7573