Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7573 | fix: ensure version option args are initialised #1960

Merged
merged 1 commit into from Apr 30, 2024

Conversation

ciaranRoche
Copy link
Member

@ciaranRoche ciaranRoche commented Apr 24, 2024

WHAT
When calling BindAndValidate the option args were not initialized, this changes ensures the args are initialized on NewRosaVersionOptions

This change also sets the checkVersion to debug in the case of any failures while trying to check the CLI version. Only when we successfully validate the version will we warn the user if its out of date.

JIRA - https://issues.redhat.com/browse/OCM-7573

@openshift-ci openshift-ci bot requested review from oriAdler and pvasant April 24, 2024 10:04
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 23.56%. Comparing base (51a6360) to head (a0b5f77).
Report is 2 commits behind head on master.

Files Patch % Lines
cmd/rosa/main.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1960      +/-   ##
==========================================
+ Coverage   23.54%   23.56%   +0.02%     
==========================================
  Files         138      138              
  Lines       21331    21333       +2     
==========================================
+ Hits         5022     5027       +5     
+ Misses      15935    15931       -4     
- Partials      374      375       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ciaranRoche
Copy link
Member Author

/cherrypick release_1.2.39

@openshift-cherrypick-robot

@ciaranRoche: once the present PR merges, I will cherry-pick it on top of release_1.2.39 in a new PR and assign it to you.

In response to this:

/cherrypick release_1.2.39

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@robpblake robpblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ciaranRoche,robpblake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@ciaranRoche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 09ec783 into openshift:master Apr 30, 2024
10 checks passed
@openshift-cherrypick-robot

@ciaranRoche: new pull request created: #1978

In response to this:

/cherrypick release_1.2.39

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants