Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM-7477 | feat: show state description for HCP upgrade policies #1945

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philipwu08
Copy link
Contributor

Added status info in state description as part of https://issues.redhat.com/browse/OCM-6654. Need to expose the state description for HCP upgrade policies.

Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: philipwu08
Once this PR has been reviewed and has the lgtm label, please assign oriadler for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.43%. Comparing base (b480a5d) to head (111a06f).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1945      +/-   ##
==========================================
+ Coverage   21.71%   22.43%   +0.71%     
==========================================
  Files         118      126       +8     
  Lines       19809    20115     +306     
==========================================
+ Hits         4302     4513     +211     
- Misses      15186    15254      +68     
- Partials      321      348      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philipwu08
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@philipwu08: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant