OCM-6592 | fix: filter out local-zone and wave-length zone associated subnets during 'rosa create machinepool (HCP)'

[davidleerh]

New PR
Resolve merge conflicts from:
#1834

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidleerh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [davidleerh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 54.76190% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 23.09%. Comparing base (a43c113) to head (f536a69).
Report is 44 commits behind head on master.

Files	Patch %	Lines
pkg/aws/client.go	73.33%	6 Missing and 2 partials ⚠️
pkg/aws/mock_client.go	0.00%	8 Missing ⚠️
cmd/create/machinepool/helper.go	0.00%	2 Missing ⚠️
cmd/create/machinepool/nodepool.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1939      +/-   ##
==========================================
+ Coverage   21.71%   23.09%   +1.37%     
==========================================
  Files         118      134      +16     
  Lines       19809    21003    +1194     
==========================================
+ Hits         4302     4850     +548     
- Misses      15186    15790     +604     
- Partials      321      363      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ciaranRoche]

/retest-required

[openshift-ci]

@davidleerh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.