Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7571 | chore: switch from ghodss/yaml to sigs.k8s.io/yaml #1918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikelolasagasti
Copy link

Module github.com/ghodss/yaml has been unmaintained for several years and sigs.k8s.io/yaml is a maintained fork.

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mikelolasagasti
Once this PR has been reviewed and has the lgtm label, please assign oriadler for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 10, 2024
Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

Hi @mikelolasagasti. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ciaranRoche
Copy link
Member

Hi @mikelolasagasti can you update the commit message to

OCM-7571 | chore: switch from ghodss/yaml to sigs.k8s.io/yaml

We created the jira to track this change, and we require it as part of the commit message before merging.

Let me know if you do not have the time to do this, we can open a PR on our side and get it merged

@ciaranRoche
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 23, 2024
Module `github.com/ghodss/yaml` has been unmaintained for several years
and `sigs.k8s.io/yaml` is a maintained fork.

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
@mikelolasagasti mikelolasagasti changed the title Switch from ghodss/yaml to sigs.k8s.io/yaml OCM-7571 | chore: switch from ghodss/yaml to sigs.k8s.io/yaml Apr 23, 2024
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

@mikelolasagasti: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test da32d16 link true /test test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants