New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-7571 | chore: switch from ghodss/yaml to sigs.k8s.io/yaml #1918
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mikelolasagasti The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mikelolasagasti. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @mikelolasagasti can you update the commit message to
We created the jira to track this change, and we require it as part of the commit message before merging. Let me know if you do not have the time to do this, we can open a PR on our side and get it merged |
/ok-to-test |
Module `github.com/ghodss/yaml` has been unmaintained for several years and `sigs.k8s.io/yaml` is a maintained fork. Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
bf616dd
to
da32d16
Compare
@mikelolasagasti: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Module
github.com/ghodss/yaml
has been unmaintained for several years andsigs.k8s.io/yaml
is a maintained fork.