OCM-6646 | fix: detect presence of --help processing args

[thomasmckay]

No description provided.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thomasmckay
Once this PR has been reviewed and has the lgtm label, please assign oriadler for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 21.30%. Comparing base (7e77d47) to head (a143544).
Report is 210 commits behind head on master.

Files	Patch %	Lines
pkg/arguments/arguments.go	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1839      +/-   ##
==========================================
- Coverage   21.30%   21.30%   -0.01%     
==========================================
  Files          91       93       +2     
  Lines       15621    15753     +132     
==========================================
+ Hits         3328     3356      +28     
- Misses      12052    12157     +105     
+ Partials      241      240       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hunterkepley]

LGTM,
only concern is if it will print the help for the subcommands (such as rosa list --help vs rosa list clusters --help

[ciaranRoche]

@thomasmckay can you ensure the ticket meets the JIRA definition of ready - https://docs.google.com/document/d/1UxSahjnmt4Ovj9y2hxcJt082j8KvJLC7CTfLKSs4HMA/edit#bookmark=id.rgd3xpx7hk0c

[robpblake]

@thomasmckay Could you please update arguments_test.go with a unit test for this.

cheers,
Rob

[thomasmckay]

updated tests, thanks!

[robpblake]

@thomasmckay I don't see the update tests file in the commits for this PR?

[thomasmckay]

LGTM, only concern is if it will print the help for the subcommands (such as rosa list --help vs rosa list clusters --help

it does work for this case

[thomasmckay]

@thomasmckay can you ensure the ticket meets the JIRA definition of ready - https://docs.google.com/document/d/1UxSahjnmt4Ovj9y2hxcJt082j8KvJLC7CTfLKSs4HMA/edit#bookmark=id.rgd3xpx7hk0c

added priority and story points to jira

[openshift-ci]

@thomasmckay: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ciaranRoche]

@thomasmckay just bumping this, can you commit the tests so we can merge this 🙏

[ciaranRoche]

@thomasmckay another bump on this one 🙏