Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cap Ingress from ADDITIONAL_ENABLED_CAPABILITIES #51424

Merged
merged 1 commit into from Apr 28, 2024

Conversation

jinyunma
Copy link
Contributor

@jinyunma jinyunma commented Apr 28, 2024

PR openshift/cluster-version-operator#946 has already been merged,

  1. remove Ingress from ADDITIONAL_ENABLED_CAPABILITIES in job config
  2. Update step cucushift-installer-check-capability and cucushift-upgrade-check-capability accordingly

@openshift-ci openshift-ci bot requested review from gpei and jianlinliu April 28, 2024 03:01
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jinyunma: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-gcp-filestore-csi-driver-operator-main-operator-e2e-extended openshift/gcp-filestore-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-gcp-filestore-csi-driver-operator-release-4.17-operator-e2e-extended openshift/gcp-filestore-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-gcp-filestore-csi-driver-operator-release-4.16-operator-e2e-extended openshift/gcp-filestore-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-gcp-filestore-csi-driver-operator-release-4.15-operator-e2e-extended openshift/gcp-filestore-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-gcp-filestore-csi-driver-operator-release-4.14-operator-e2e-extended openshift/gcp-filestore-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-master-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-release-4.17-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-release-4.16-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-release-4.15-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-release-4.14-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.17-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.16-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.15-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.14-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.13-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.12-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.11-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-ibm-vpc-node-label-updater-release-4.15-e2e-ibmcloud-csi-extended openshift/ibm-vpc-node-label-updater presubmit Registry content changed
pull-ci-openshift-ibm-vpc-node-label-updater-release-4.14-e2e-ibmcloud-csi-extended openshift/ibm-vpc-node-label-updater presubmit Registry content changed
pull-ci-openshift-csi-operator-master-e2e-aws-csi-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.17-e2e-aws-csi-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.16-e2e-aws-csi-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.15-e2e-aws-csi-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-master-e2e-azure-csi-extended openshift/csi-operator presubmit Registry content changed

A total of 3116 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jinyunma
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-gcp-ipi-basecap-none-additionalcaps-arm-f7

@openshift-ci-robot
Copy link
Contributor

@jinyunma: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jinyunma
Copy link
Contributor Author

//pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-aws-upi-basecap-none-amd-f28

@jinyunma
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-aws-upi-basecap-none-amd-f28

@openshift-ci-robot
Copy link
Contributor

@jinyunma: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2024
@jinyunma
Copy link
Contributor Author

/pj-rehearse ack

cc @liangxia to review
cc @jiajliu @sunzhaohua2 @shellyyang1989 @lihongan for awareness.

@openshift-ci-robot
Copy link
Contributor

@jinyunma: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 28, 2024
@liangxia
Copy link
Member

/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianlinliu, jinyunma, liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1d3eeaf into openshift:master Apr 28, 2024
17 of 19 checks passed
Copy link
Contributor

openshift-ci bot commented Apr 28, 2024

@jinyunma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-aws-upi-basecap-none-amd-f28 72c6cd6 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-aws-upi-basecap-none-amd-f28

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jinyunma jinyunma deleted the remove_cap_ingress branch April 28, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants