Add scos tag to machine-config-operator images when building on OKD for scos

[Prashanth684]

Avoid the below error when building a release image for OKD:

operator "machine-config-operator" contained an invalid image-references file: no input image tag named "rhel-coreos"

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@Prashanth684: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-machine-config-operator-master-okd-scos-images	openshift/machine-config-operator	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[Prashanth684]

/pj-rehearse pull-ci-openshift-machine-config-operator-master-okd-scos-images

[openshift-ci-robot]

@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@Prashanth684: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/machine-config-operator/master/okd-scos-images	d496d3d	link	unknown	/pj-rehearse pull-ci-openshift-machine-config-operator-master-okd-scos-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Prashanth684]

@LorbusChris after adding the scos tag, the release image step still fails to build the release image because of the same error..anything I'm missing?

[LorbusChris]

Found it: In the meantime a build without TAGS=scos has been built and pushed so the image currently present in the IS (registry.ci.openshift.org/origin/scos-4.16:machine-config-operator) contains references to rhel-coreos, which makes the test fail at initial release install:

$ podman run -it --rm --entrypoint bash registry.ci.openshift.org/origin/scos-4.16:machine-config-operator
# cat /manifests/image-references | grep rhel-coreos
  - name: rhel-coreos
      name: placeholder.url.oc.will.replace.this.org/placeholdernamespace:rhel-coreos
  - name: rhel-coreos-extensions
      name: placeholder.url.oc.will.replace.this.org/placeholdernamespace:rhel-coreos-extensions

Therefore rehearsals cannot pass currently. Let's merge this and see if the issue goes away after we have a proper SCOS build on the image stream.

/lgtm
/pj-rehearse ack

[openshift-ci-robot]

@LorbusChris: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[yuqi-zhang]

Seems sane to me

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, Prashanth684, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/machine-config-operator/OWNERS [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment