Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERFSCALE-2860 - Re-enable jobs on new schedule balancing #51420
PERFSCALE-2860 - Re-enable jobs on new schedule balancing #51420
Changes from all commits
bd84b15
1057d4c
89b1d1e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afcollins Could you help me to understand why these dates was configured? Do you try to run different jobs on different days? What is the difference between the current config and day-of-week config like 0 0 * * 3 and 0 0 * * 4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea with specifying days like this is to allow us to create a weekly/bi-weekly/monthly schedule. The day-of-week format
0 12 * * 1
means "run on Mondays", but I couldn't find any way to say "Run on every-other Monday".By writing a weekly schedule like this, we can know the total number of jobs running on any given day/week/month.
"Month" i.e. 28 days and chop up from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood, I agree it's easier to understand by having a unified format.