Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test sdn live migration ovn #51412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test sdn live migration ovn #51412

wants to merge 1 commit into from

Conversation

weliang1
Copy link
Contributor

@weliang1 weliang1 commented Apr 26, 2024 •
edited

@zhaozhanqi @liangxia PTAL!

  • The existing Prow CI workflows from sdn-migration-ovn are for offline migration. This new workflow supports live migration from SDN to OVN,
  • This new workflow is aimed to address both https://issues.redhat.com/browse/NP-962 and https://issues.redhat.com/browse/NP-916
  • The filename -ovn-sdn-live-migration-ovn- in the workflow appears odd, but it cannot be changed due to the compile error below
$ sudo make jobs
false || docker pull --platform linux/amd64 registry.ci.openshift.org/ci/ci-operator-checkconfig:latest
latest: Pulling from ci/ci-operator-checkconfig
Digest: sha256:9b729bc82739fd685d1f8266fc6ae46b555c54c5ec0c0e92eaa2e72c060bd006
Status: Image is up to date for registry.ci.openshift.org/ci/ci-operator-checkconfig:latest
registry.ci.openshift.org/ci/ci-operator-checkconfig:latest
docker run --platform linux/amd64 --user 0:0 --rm -v "/home/weliang/go/src/Prow/4-27/release/ci-operator/config:/ci-operator/config:z" -v "/home/weliang/go/src/Prow/4-27/release/ci-operator/step-registry:/ci-operator/step-registry:z" -v "/home/weliang/go/src/Prow/4-27/release/ci-operator/step-registry/cluster-profiles:/ci-operator/step-registry/cluster-profiles:z" -v "/home/weliang/go/src/Prow/4-27/release/core-services/cluster-pools:/core-services/cluster-pools:z" registry.ci.openshift.org/ci/ci-operator-checkconfig:latest --config-dir /ci-operator/config --registry /ci-operator/step-registry --cluster-profiles-config /ci-operator/step-registry/cluster-profiles/cluster-profiles-config.yaml --cluster-claim-owners-config /core-services/cluster-pools/_config.yaml
time="2024-04-26T15:48:23Z" level=fatal msg="failed to parse arguments" error="failed to load registry: file /ci-operator/step-registry/ovn/sdn-live-migration-ovn/ovn-sdn-live-migration-commands.sh has incorrect prefix. Prefix should be ovn-sdn-live-migration-ovn"
make: *** [Makefile:78: ci-operator-checkconfig] Error 1

@weliang1
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-vsphere-ipi-sdn-live-migration-ovn-f28

@openshift-ci-robot
Copy link
Contributor

@weliang1: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@liangxia
Copy link
Member

  • The filename -ovn-sdn-live-migration-ovn- in the workflow appears odd, but it cannot be changed due to the compile error below

This is because it's in path step-registry/ovn/sdn-live-migration-ovn/.
If you'd like the file name to be sdn-live-migration-ovn-, you can move the folder sdn-live-migration-ovn directly under folder step-registry.

@weliang1
Copy link
Contributor Author

  • The filename -ovn-sdn-live-migration-ovn- in the workflow appears odd, but it cannot be changed due to the compile error below

This is because it's in path step-registry/ovn/sdn-live-migration-ovn/. If you'd like the file name to be sdn-live-migration-ovn-, you can move the folder sdn-live-migration-ovn directly under folder step-registry.

@liangxia Thanks for the explanation. The SDN will not be supported in 4.17 any more and we do not need this workflow in 4.17 branch. If you think it is OK, I would keep using -ovn-sdn-live-migration-ovn- in the workflow.

zhaozhanqi
zhaozhanqi reviewed Apr 30, 2024
View reviewed changes
...t/openshift-tests-private/openshift-openshift-tests-private-release-4.16__amd64-nightly.yaml
@@ -2708,6 +2708,15 @@ tests:
test:
- chain: openshift-e2e-test-qe-destructive
workflow: cucushift-installer-rehearse-vsphere-ipi-remote-worker
- as: vsphere-ipi-sdn-live-migration-ovn-f28
cron: 39 9 1,17 * *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the cron job time by ./ci-operator/config/openshift/openshift-tests-private/tools/generate-cron-entry.sh tool generate a new one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhaozhanqi Update it by using above tool.

zhaozhanqi
zhaozhanqi reviewed Apr 30, 2024
View reviewed changes
...t/openshift-tests-private/openshift-openshift-tests-private-release-4.16__amd64-nightly.yaml Outdated
OVERRIDE_OPENSHIFT_SDN_DEPRECATION: "true"
test:
- chain: cucushift-sdn-live-migration-ovn
workflow: cucushift-installer-rehearse-vsphere-ipi-sdn
- as: vsphere-ipi-sdn-migration-ovn-f14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we can remove this one if live migration ready for customer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhaozhanqi Agree, we can remove the offline migration workflow until this new live migration released in 4.16.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this profile in 4.16 if so?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhaozhanqi Done!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhaozhanqi @liangxia Please let me know if you have any more comments. Hope it can be merged before my PTO starting from 5/9, thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/lgtm

@weliang1 weliang1 closed this May 7, 2024
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 7, 2024
@weliang1 weliang1 reopened this May 7, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@weliang1: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-vsphere-ipi-sdn-live-migration-ovn-f28 N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

@weliang1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liangxia
Copy link
Member

liangxia commented May 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@zhaozhanqi
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liangxia, weliang1, zhaozhanqi
Once this PR has been reviewed and has the lgtm label, please assign jluhrsen for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaozhanqi zhaozhanqi zhaozhanqi left review comments

@abhat abhat Awaiting requested review from abhat

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@zhaozhanqi zhaozhanqi

@liangxia liangxia

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
4 participants
@weliang1 @openshift-ci-robot @liangxia @zhaozhanqi