Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubmission of #50929 with fixes #51393

Merged

Conversation

fxierh
Copy link
Contributor

@fxierh fxierh commented Apr 26, 2024

#50929 was reverted by #51372 due to the fact that HC_ZONES was mistakenly written as HC_ZONEs in the following section:

HC_ZONEs="${HYPERSHIFT_HC_ZONES}"
if [[ -z "$HC_ZONEs" ]]; then
HC_ZONES="$(oc get node -o jsonpath='{.items[0].metadata.labels.topology\.kubernetes\.io/zone}')"
fi

causing periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn-conformance to fail in the following way:

/bin/bash: line 30: HC_ZONES: unbound variable 

This PR re-submits #50929 with fixes.

Rehearsal results:
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-ipi-ovn-hypershift-private-mgmt-f7: ok
periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn-conformance: ok
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-ipi-ovn-hypershift-private-guest-f7: ok (step phase pre & post passed)
periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance-serial: ok (step phase pre & post passed)
periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn-proxy-conformance: failed due to an unrelated error (this job also failed in the same way)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2024
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fxierh
Copy link
Contributor Author

fxierh commented Apr 26, 2024

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-ipi-ovn-hypershift-private-mgmt-f7 periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-ipi-ovn-hypershift-private-guest-f7 periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn-conformance periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance-serial

@openshift-ci-robot
Copy link
Contributor

@fxierh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@fxierh
Copy link
Contributor Author

fxierh commented Apr 26, 2024

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-ipi-ovn-hypershift-private-mgmt-f7 periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-ipi-ovn-hypershift-private-guest-f7

@openshift-ci-robot
Copy link
Contributor

@fxierh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@fxierh
Copy link
Contributor Author

fxierh commented Apr 26, 2024

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn-proxy-conformance

@openshift-ci-robot
Copy link
Contributor

@fxierh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@fxierh
Copy link
Contributor Author

fxierh commented Apr 28, 2024

/cc @csrwng
/cc @jianlinliu
/cc @liangxia
/cc @heliubj18

Could you please review the sections you are responsible for in the resubmitted PR ? Thank you.
(Sorry for tagging you for the same thing again)

@fxierh fxierh marked this pull request as ready for review April 28, 2024 07:39
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2024
@openshift-ci openshift-ci bot requested a review from kuiwang02 April 28, 2024 07:40
@fxierh
Copy link
Contributor Author

fxierh commented Apr 28, 2024

/cc @jupierce

This PR has been thoroughly rehearsed and should be okay, but could you please take a look to ensure the issues have been resolved appropriately? Thank you.

@openshift-ci openshift-ci bot requested a review from jupierce April 28, 2024 07:42
@liangxia
Copy link
Member

One of the required job failed

ci/prow/core-valid — Job failed.  

@fxierh
Copy link
Contributor Author

fxierh commented Apr 28, 2024

Just a rebase.

@fxierh
Copy link
Contributor Author

fxierh commented Apr 28, 2024

/pj-rehearse periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn-conformance periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance-serial

For safety.

@openshift-ci-robot
Copy link
Contributor

@fxierh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@fxierh
Copy link
Contributor Author

fxierh commented Apr 28, 2024

@jianlinliu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@heliubj18
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@fxierh
Copy link
Contributor Author

fxierh commented Apr 30, 2024

/test ci-operator-registry

@fxierh
Copy link
Contributor Author

fxierh commented May 6, 2024

/assign @liangxia

Could you please take a look ? Thanks.

@liangxia
Copy link
Member

liangxia commented May 8, 2024

/approve

1 similar comment
@sjenning
Copy link
Contributor

sjenning commented May 8, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@fxierh
Copy link
Contributor Author

fxierh commented May 8, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@fxierh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 8, 2024
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@fxierh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-ipi-ovn-hypershift-private-guest-f7 df29ba4 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-ipi-ovn-hypershift-private-guest-f7
ci/rehearse/periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn-proxy-conformance df29ba4 link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn-proxy-conformance
ci/rehearse/periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance-serial 4d286fe link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Signed-off-by: Feilian Xie <fxie@redhat.com>
@fxierh fxierh force-pushed the hcp-aws-priv-resubmission branch from ef48201 to bbc50ca Compare May 8, 2024 20:48
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@fxierh
Copy link
Contributor Author

fxierh commented May 8, 2024

Had to rebase due to #51645.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 8, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@fxierh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.17-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.16-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.15-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.14-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.13-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.12-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.11-e2e-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-etcd-openshift-4.17-e2e-hypershift-conformance openshift/etcd presubmit Registry content changed
pull-ci-openshift-etcd-openshift-4.16-e2e-hypershift-conformance openshift/etcd presubmit Registry content changed
pull-ci-openshift-etcd-openshift-4.15-e2e-hypershift-conformance openshift/etcd presubmit Registry content changed
pull-ci-openshift-etcd-openshift-4.14-e2e-hypershift-conformance openshift/etcd presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.13-e2e-hypershift-ovn-conformance openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-master-e2e-hypershift-pao openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.17-e2e-hypershift-pao openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-node-tuning-operator-release-4.16-e2e-hypershift-pao openshift/cluster-node-tuning-operator presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-master-e2e-hypershift-conformance openshift/cluster-version-operator presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-release-4.17-e2e-hypershift-conformance openshift/cluster-version-operator presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-release-4.16-e2e-hypershift-conformance openshift/cluster-version-operator presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-release-4.15-e2e-hypershift-conformance openshift/cluster-version-operator presubmit Registry content changed
pull-ci-openshift-cluster-version-operator-release-4.14-e2e-hypershift-conformance openshift/cluster-version-operator presubmit Registry content changed
pull-ci-openshift-hypershift-main-e2e-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.17-e2e-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.16-e2e-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.15-e2e-conformance openshift/hypershift presubmit Registry content changed

A total of 245 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@fxierh
Copy link
Contributor Author

fxierh commented May 8, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@fxierh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 8, 2024
@heliubj18
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxierh, heliubj18, jianlinliu, liangxia, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit dc31e8e into openshift:master May 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
7 participants