Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hypershift, kubevirt: Add network type to relevant periodic jobs #51392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

hypershift, kubevirt: Add network type to relevant periodic jobs #51392

wants to merge 1 commit into from
+31 −31

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented Apr 26, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from enxebre and sjenning April 26, 2024 07:32
davidvossel
davidvossel reviewed Apr 26, 2024
View reviewed changes
ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.14-periodics.yaml Outdated
Comment on lines 883 to 890
name: periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-metal-mce
reporter_config:
slack:
channel: '#hypershift-kubevirt-platform'
job_states_to_report:
- failure
report_template: ':volcano: Job *{{.Spec.Job}}* ended with *{{.Status.State}}*.
<{{.Status.URL}}|View logs> :volcano:'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For whatever reason, when we re-name a job, the slack reporting gets stripped out of the job yaml. This needs to be added back

@qinqon qinqon force-pushed the hypershift-kubevirt-perdiocis-network-type-job-names branch 3 times, most recently from 6457c0e to 30d3f23 Compare April 29, 2024 13:06
@qinqon qinqon requested a review from davidvossel April 29, 2024 13:06
davidvossel
davidvossel reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@qinqon
Copy link
Contributor Author

qinqon commented May 9, 2024

/pj-rehearsal ack

@qinqon
Copy link
Contributor Author

qinqon commented May 9, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@qinqon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 9, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c94016e and 2 for PR HEAD 30d3f23 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4f0d245 and 1 for PR HEAD 30d3f23 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 89d1bd2 and 0 for PR HEAD 30d3f23 in total

@qinqon
hypershift, kubevirt: Add network type to relevant periodic jobs
9e234f3 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon qinqon force-pushed the hypershift-kubevirt-perdiocis-network-type-job-names branch from 30d3f23 to 9e234f3 Compare May 9, 2024 12:34
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@qinqon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-kubevirt-metal-ovn N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-metal-ovn-mce N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-kubevirt-metal-ovn-mce N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@qinqon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel davidvossel left review comments

@enxebre enxebre Awaiting requested review from enxebre

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@davidvossel davidvossel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
3 participants
@qinqon @openshift-ci-robot @davidvossel