Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/ocmprovider: remove ccs overwrite logic #1383

Merged

Conversation

jbpratt
Copy link
Contributor

@jbpratt jbpratt commented Nov 9, 2022

remove the ccs.overwrite setting and logic as it is no longer needed/used

Signed-off-by: Brady Pratt bpratt@redhat.com

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2022
@MrSantamaria
Copy link
Contributor

We can remove this whole logic.
This is a remnant attempt of mine trying to figure out multi clusters in a single account back when osdccsadmin was a thing.

@jbpratt jbpratt changed the title providers/ocmprovider: move ccs keys overwrite log providers/ocmprovider: remove ccs overwrite logic Nov 9, 2022
remove the ccs.overwrite setting and logic as it is no longer
needed/used

Signed-off-by: Brady Pratt <bpratt@redhat.com>
@jbpratt
Copy link
Contributor Author

jbpratt commented Nov 9, 2022

We can remove this whole logic. This is a remnant attempt of mine trying to figure out multi clusters in a single account back when osdccsadmin was a thing.

Thanks for the note, updated to remove all the overwrite logic!

FWIW I still do multiple ccs clusters (and rosa sts) in the same account, osdCcsAdmin is still a thing that I use 😸

@MrSantamaria
Copy link
Contributor

It is something we can use for sure.
In the olden days anytime rosa init was called it cycled keys and it was near impossible to keep aws credentials for the osd flavors.

@jbpratt
Copy link
Contributor Author

jbpratt commented Nov 10, 2022

It is something we can use for sure. In the olden days anytime rosa init was called it cycled keys and it was near impossible to keep aws credentials for the osd flavors.

😏 openshift/rosa#637

@MrSantamaria
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbpratt, MrSantamaria

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MrSantamaria,jbpratt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

@jbpratt: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 525769b into openshift:main Nov 10, 2022
@jbpratt jbpratt deleted the move-ccs-generate-key-log branch November 10, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants