CFE-853: e2e test case for DNSNameResolver and EgressFirewall integration #28683

bharath-b-rh · 2024-04-03T05:03:19Z

e2e test case covering integration of CoreDNS and EgressFirewall as proposed in the enhancement

openshift-ci-robot · 2024-04-03T05:03:22Z

@bharath-b-rh: This pull request references CFE-853 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

e2e test case covering integration of CoreDNS and EgressFirewall as proposed in the enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-trt-bot · 2024-04-03T12:40:40Z

Job Failure Risk Analysis for sha: e45eced

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-sdn	IncompleteTests Tests for this run (19) are below the historical average (1422): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade	IncompleteTests Tests for this run (20) are below the historical average (2222): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial	Low [sig-arch] events should not repeat pathologically for ns/openshift-etcd-operator This test has passed 30.00% of 70 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node-serial'] in the last 14 days.

test/extended/testdata/egress-firewall/ovnk-egressfirewall-wildcard-test.yaml

test/extended/networking/egress_firewall.go

openshift-trt-bot · 2024-04-10T07:53:59Z

Job Failure Risk Analysis for sha: eea9b02

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade	High [sig-apps] job-upgrade This test has passed 100.00% of 39 runs on jobs ['periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn-upgrade'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-aws-ovn-serial	Medium [bz-networking][invariant] alert/OVNKubernetesResourceRetryFailure should not be at or above info This test has passed 97.67% of 43 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn-serial'] in the last 14 days. Open Bugs Help needed understanding 4.16 upgrade duration increase on metal

arkadeepsen · 2024-04-22T08:25:51Z

/retest

openshift-trt-bot · 2024-04-22T12:04:08Z

Job Failure Risk Analysis for sha: e0d9b06

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd	IncompleteTests Tests for this run (19) are below the historical average (664): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial	Low [sig-arch] events should not repeat pathologically for ns/openshift-etcd-operator This test has passed 52.83% of 53 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node-serial'] in the last 14 days.

arkadeepsen · 2024-04-22T12:47:51Z

/retest

npinaeva

some nits

test/extended/networking/egress_firewall.go

bharath-b-rh · 2024-04-24T05:21:06Z

/retest-required

openshift-trt-bot · 2024-04-24T06:10:05Z

Job Failure Risk Analysis for sha: b03d1c5

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6	IncompleteTests Tests for this run (13) are below the historical average (962): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

droslean · 2024-04-24T09:36:31Z

/retest

openshift-trt-bot · 2024-04-24T10:05:06Z

Job Failure Risk Analysis for sha: 462231d

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-openstack-ovn	IncompleteTests Tests for this run (2) are below the historical average (1763): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade	IncompleteTests Tests for this run (2) are below the historical average (726): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade	IncompleteTests Tests for this run (2) are below the historical average (642): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-ovn-builds	IncompleteTests Tests for this run (2) are below the historical average (674): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-ovn	IncompleteTests Tests for this run (2) are below the historical average (1611): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-csi	IncompleteTests Tests for this run (2) are below the historical average (643): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade	IncompleteTests Tests for this run (2) are below the historical average (750): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade	IncompleteTests Tests for this run (2) are below the historical average (2376): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial	IncompleteTests Tests for this run (2) are below the historical average (780): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node	IncompleteTests Tests for this run (2) are below the historical average (1781): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2	IncompleteTests Tests for this run (2) are below the historical average (1797): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

bharath-b-rh · 2024-04-24T10:56:52Z

/test verify

bharath-b-rh · 2024-04-24T12:11:24Z

/test verify

kyrtapz · 2024-05-15T13:56:53Z

test/extended/networking/egress_firewall.go

 			})
 		},
 	)
+
+	// When OVNKubernetes subnet and coredns-ocp-dnsnameresolver plugins are enabled.


Instead of checking whether the cluster is techpreview you should create featuregate specific tests:
https://github.com/openshift/api?tab=readme-ov-file#defining-featuregate-e2e-tests
Example: #28719

I am thinking we will make a whole new context in the next dev cycle following all instructions ^, but we wanted 1 simple test in the existing context before we even merge tech preview feature. Hopefully that makes sense

thanks for the link btw!

not sure if this helps, but some existing tests actually were an example for this one

origin/test/extended/builds/volumes.go

Lines 161 to 163 in 75f2c02

if !exutil.IsTechPreviewNoUpgrade(oc) {

g.Skip("the test is not expected to work within Tech Preview disabled clusters")

}

The approach of testing featuregates is fairly new as far as I know. I think it is better than checking for techpreview because it doesn't require any followup work. It should be really easy to test whether it works in the existing g.It

suggestion incorporated. New Describe block added with OCPFeatureGate tag.

openshift-trt-bot · 2024-05-15T15:32:14Z

Job Failure Risk Analysis for sha: 215dccb

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade	High [sig-network-edge] Verify DNS availability during and after upgrade success This test has passed 99.40% of 1503 runs on release 4.17 [Overall] in the last week.

…tion

bharath-b-rh · 2024-05-16T06:45:01Z

/test e2e-gcp-ovn-upgrade

bharath-b-rh · 2024-05-16T06:46:24Z

/test e2e-gcp-csi

npinaeva · 2024-05-16T08:55:25Z

To do the test run here we need to wait for the last approved pr openshift/cluster-network-operator#2131 to be included to the ~~nightly~~ ci image (which may take quite some time, and the FF is tomorrow). So do you think we can merge this test based on my manual test run with the latest CNO changes https://gist.github.com/npinaeva/021cddfeff438dd2506b8728cb93367f? @kyrtapz @trozet
UPDATE: talked to Patryk, we agreed to wait at least till the evening hoping to get a fresh ci image to test
UPDATE2: we agreed to wait as much as needed to get a green Ci run here and backport if we don't merge it before FF

bharath-b-rh · 2024-05-16T08:58:12Z

/test e2e-agnostic-ovn-cmd

kyrtapz · 2024-05-16T09:00:43Z

/test ?

openshift-ci · 2024-05-16T09:01:01Z

@kyrtapz: The following commands are available to trigger required jobs:

/test e2e-aws-jenkins
/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-image-registry
/test e2e-aws-ovn-serial
/test e2e-gcp-ovn
/test e2e-gcp-ovn-builds
/test e2e-gcp-ovn-image-ecosystem
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test images
/test lint
/test unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
/test e2e-agnostic-ovn-cmd
/test e2e-aws
/test e2e-aws-csi
/test e2e-aws-disruptive
/test e2e-aws-etcd-recovery
/test e2e-aws-multitenant
/test e2e-aws-ovn
/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-etcd-scaling
/test e2e-aws-ovn-kubevirt
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-single-node-serial
/test e2e-aws-ovn-single-node-upgrade
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-upi
/test e2e-aws-proxy
/test e2e-azure
/test e2e-azure-ovn-etcd-scaling
/test e2e-azure-ovn-upgrade
/test e2e-baremetalds-kubevirt
/test e2e-gcp-csi
/test e2e-gcp-disruptive
/test e2e-gcp-fips-serial
/test e2e-gcp-ovn-etcd-scaling
/test e2e-gcp-ovn-rt-upgrade
/test e2e-gcp-ovn-techpreview
/test e2e-gcp-ovn-techpreview-serial
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-dualstack-local-gateway
/test e2e-metal-ipi-sdn
/test e2e-metal-ipi-serial
/test e2e-metal-ipi-serial-ovn-ipv6
/test e2e-metal-ipi-virtualmedia
/test e2e-openstack-ovn
/test e2e-openstack-serial
/test e2e-vsphere
/test e2e-vsphere-ovn-dualstack-primaryv6
/test e2e-vsphere-ovn-etcd-scaling
/test okd-e2e-gcp
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
pull-ci-openshift-origin-master-e2e-aws-csi
pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones
pull-ci-openshift-origin-master-e2e-aws-ovn-fips
pull-ci-openshift-origin-master-e2e-aws-ovn-serial
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
pull-ci-openshift-origin-master-e2e-gcp-csi
pull-ci-openshift-origin-master-e2e-gcp-ovn
pull-ci-openshift-origin-master-e2e-gcp-ovn-builds
pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-origin-master-e2e-metal-ipi-sdn
pull-ci-openshift-origin-master-e2e-openstack-ovn
pull-ci-openshift-origin-master-images
pull-ci-openshift-origin-master-lint
pull-ci-openshift-origin-master-unit
pull-ci-openshift-origin-master-verify
pull-ci-openshift-origin-master-verify-deps

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kyrtapz · 2024-05-17T08:18:39Z

/test e2e-gcp-ovn-techpreview

trozet

/lgtm

trozet · 2024-05-17T12:58:51Z

/acknowledge-critical-fixes-only

trozet · 2024-05-17T12:59:02Z

/label acknowledge-critical-fixes-only

trozet · 2024-05-17T13:00:51Z

/approve

dgoodwin · 2024-05-17T14:41:26Z

/approve

openshift-ci · 2024-05-17T14:41:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh, dgoodwin, npinaeva, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dgoodwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-05-17T16:51:47Z

/retest-required

Remaining retests: 0 against base HEAD 0707859 and 2 for PR HEAD 09375ea in total

arkadeepsen · 2024-05-17T19:52:15Z

/test e2e-aws-ovn-serial

openshift-ci · 2024-05-17T20:49:08Z

@bharath-b-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade	`09375ea`	link	false	`/test e2e-aws-ovn-single-node-upgrade`
ci/prow/e2e-agnostic-ovn-cmd	`09375ea`	link	false	`/test e2e-agnostic-ovn-cmd`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-trt-bot · 2024-05-17T21:08:42Z

Job Failure Risk Analysis for sha: 09375ea

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-serial	IncompleteTests Tests for this run (95) are below the historical average (1004): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

arkadeepsen · 2024-05-17T21:18:35Z

/test e2e-aws-ovn-serial

openshift-bot · 2024-05-18T02:50:30Z

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.17.0-202405180141.p0.g8cca3af.assembly.stream.el9 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2024

openshift-ci bot requested review from deads2k and trozet April 3, 2024 05:04

bharath-b-rh force-pushed the cfe-853 branch from 707ce30 to e45eced Compare April 3, 2024 09:22

bharath-b-rh force-pushed the cfe-853 branch from e45eced to 622e9af Compare April 5, 2024 09:41

arkadeepsen reviewed Apr 8, 2024

View reviewed changes

bharath-b-rh force-pushed the cfe-853 branch from eea9b02 to e0d9b06 Compare April 11, 2024 10:28

This was referenced Apr 22, 2024

CFE-1049: Add tech-preview e2e in CI config for cluster-network-operator openshift/release#51201

Merged

CFE-888: Enable DNSNameResolver feature-gate openshift/cluster-network-operator#2131

Merged

npinaeva reviewed Apr 22, 2024

View reviewed changes

test/extended/networking/egress_firewall.go Outdated Show resolved Hide resolved

test/extended/networking/egress_firewall.go Show resolved Hide resolved

test/extended/networking/egress_firewall.go Outdated Show resolved Hide resolved

bharath-b-rh force-pushed the cfe-853 branch 2 times, most recently from 791f5f5 to e5cebf5 Compare April 23, 2024 09:33

arkadeepsen reviewed Apr 23, 2024

View reviewed changes

test/extended/networking/egress_firewall.go Outdated Show resolved Hide resolved

bharath-b-rh force-pushed the cfe-853 branch from e5cebf5 to b03d1c5 Compare April 23, 2024 12:22

openshift-ci bot added e2e-images-update Related to images used by e2e tests vendor-update Touching vendor dir or related files labels Apr 24, 2024

bharath-b-rh force-pushed the cfe-853 branch from a625546 to 462231d Compare April 24, 2024 09:30

bharath-b-rh force-pushed the cfe-853 branch from 462231d to 04c40a3 Compare April 24, 2024 14:02

bharath-b-rh force-pushed the cfe-853 branch from 77d042b to 215dccb Compare May 15, 2024 12:17

kyrtapz reviewed May 15, 2024

View reviewed changes

CFE-853: e2e test case for DNSNameResolver and EgressFirewall integra…

09375ea

…tion

bharath-b-rh force-pushed the cfe-853 branch from 215dccb to 09375ea Compare May 16, 2024 03:23

trozet approved these changes May 17, 2024

View reviewed changes

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 17, 2024

openshift-ci bot assigned trozet May 17, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024

openshift-merge-bot bot merged commit 8cca3af into openshift:master May 17, 2024
23 of 25 checks passed

bharath-b-rh deleted the cfe-853 branch May 19, 2024 17:17

	if !exutil.IsTechPreviewNoUpgrade(oc) {
	g.Skip("the test is not expected to work within Tech Preview disabled clusters")
	}

CFE-853: e2e test case for DNSNameResolver and EgressFirewall integration #28683

CFE-853: e2e test case for DNSNameResolver and EgressFirewall integration #28683

Conversation

bharath-b-rh commented Apr 3, 2024

openshift-ci-robot commented Apr 3, 2024 • edited by openshift-ci bot

openshift-trt-bot commented Apr 3, 2024

openshift-trt-bot commented Apr 10, 2024

arkadeepsen commented Apr 22, 2024

openshift-trt-bot commented Apr 22, 2024

arkadeepsen commented Apr 22, 2024

npinaeva left a comment

Choose a reason for hiding this comment

bharath-b-rh commented Apr 24, 2024

openshift-trt-bot commented Apr 24, 2024

droslean commented Apr 24, 2024

openshift-trt-bot commented Apr 24, 2024

bharath-b-rh commented Apr 24, 2024

bharath-b-rh commented Apr 24, 2024

kyrtapz May 15, 2024

Choose a reason for hiding this comment

npinaeva May 15, 2024

Choose a reason for hiding this comment

npinaeva May 15, 2024

Choose a reason for hiding this comment

npinaeva May 15, 2024

Choose a reason for hiding this comment

kyrtapz May 15, 2024

Choose a reason for hiding this comment

bharath-b-rh May 16, 2024

Choose a reason for hiding this comment

openshift-trt-bot commented May 15, 2024

bharath-b-rh commented May 16, 2024

bharath-b-rh commented May 16, 2024

npinaeva commented May 16, 2024 • edited

bharath-b-rh commented May 16, 2024

kyrtapz commented May 16, 2024

openshift-ci bot commented May 16, 2024

kyrtapz commented May 17, 2024

trozet left a comment

Choose a reason for hiding this comment

trozet commented May 17, 2024

trozet commented May 17, 2024

trozet commented May 17, 2024

dgoodwin commented May 17, 2024

openshift-ci bot commented May 17, 2024

openshift-ci-robot commented May 17, 2024

arkadeepsen commented May 17, 2024

openshift-ci bot commented May 17, 2024 • edited

openshift-trt-bot commented May 17, 2024

arkadeepsen commented May 17, 2024

openshift-bot commented May 18, 2024

openshift-ci-robot commented Apr 3, 2024 •

edited by openshift-ci bot

npinaeva commented May 16, 2024 •

edited

openshift-ci bot commented May 17, 2024 •

edited