Merge pull request #20015 from mfojtik/dockercfg

serviceaccounts: do not manage pull secrets created by third parties
openshift · Jun 15, 2018 · 411637b · 411637b
2 parents 06d4b3a + 2678448
commit 411637b
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/pkg/serviceaccounts/controllers/docker_registry_service.go b/pkg/serviceaccounts/controllers/docker_registry_service.go
@@ -287,6 +287,13 @@ func (e *DockerRegistryServiceController) syncRegistryLocationChange() error {
 			if t.Type != v1.SecretTypeDockercfg {
 				continue
 			}
+			if t.Annotations == nil {
+				continue
+			}
+			// Do not manage dockercfg secrets we haven't created (eg. secrets created by user for private repositories).
+			if _, hasTokenSecret := t.Annotations[ServiceAccountTokenSecretNameKey]; !hasTokenSecret {
+				continue
+			}
 		default:
 			utilruntime.HandleError(fmt.Errorf("object passed to %T that is not expected: %T", e, obj))
 			continue