Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS 10276:Modified acme-cluster-issuer yaml file to add ingress class name #75220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSDOCS 10276:Modified acme-cluster-issuer yaml file to add ingress class name #75220

wants to merge 1 commit into from

Conversation

subhtk
Copy link
Contributor

@subhtk subhtk commented Apr 26, 2024 •
edited

Version(s): 4.13+

Issue: OSDOCS-10276

Link to docs preview: docs preview

SME review:

  • SME has approved this change.

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 26, 2024 •
edited

🤖 Thu May 09 09:14:21 - Prow CI generated the docs preview:

https://75220--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/cert_manager_operator/cert-manager-operator-issuer-acme.html

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2024
@swghosh
Copy link
Member

swghosh commented Apr 29, 2024

/cc @anirudhAgniRedhat

@swghosh
Copy link
Member

swghosh commented Apr 29, 2024

/lgtm
Note: please backport this to prior versions since ti's originated as a bug!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@anirudhAgniRedhat
Copy link

/cc @anirudhAgniRedhat

looks good to me.

@subhtk
Copy link
Contributor Author

subhtk commented Apr 30, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 30, 2024
@mburke5678 mburke5678 added this to the Continuous Release milestone Apr 30, 2024
@mburke5678
Copy link
Contributor

@subhtk A couple of comments. Otherwise LGTM

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 30, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 9, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 9, 2024

@subhtk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-asciidoc c790d42 link true /test validate-asciidoc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

lunarwhite
lunarwhite reviewed May 10, 2024
View reviewed changes
modules/cert-manager-acme-http01.adoc
----
$ oc patch ingress/<ingress-name> --type=merge --patch '{"spec":{"ingressClassName":"openshift-default"}}' -n <namespace>
----
====
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
====

I think you also intend to remove this line of notations.

Otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

@lunarwhite lunarwhite lunarwhite left review comments

@anirudhAgniRedhat anirudhAgniRedhat Awaiting requested review from anirudhAgniRedhat

Assignees

@swghosh swghosh

Labels
branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@subhtk @ocpdocs-previewbot @swghosh @anirudhAgniRedhat @mburke5678 @lunarwhite