Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-load-balancer-operator: fix mistakes in STS installation using AWS CLI #75219

Merged
merged 1 commit into from Apr 29, 2024
Merged

aws-load-balancer-operator: fix mistakes in STS installation using AWS CLI #75219

merged 1 commit into from Apr 29, 2024

Conversation

alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Apr 26, 2024 •
edited by mburke5678

I found a drift from the developer documentation for the ALBO installation instructions on STS cluster using AWS CLI.

Version(s): 4.15, 4.14

Issue: N/A

Link to docs preview: https://75219--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/aws_load_balancer_operator/installing-albo-sts-cluster.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 26, 2024
@ocpdocs-previewbot
Copy link

🤖 Fri Apr 26 14:06:51 - Prow CI generated the docs preview:

https://75219--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/aws_load_balancer_operator/installing-albo-sts-cluster.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 26, 2024

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jmanthei
Copy link
Contributor

/label peer-review-needed

@ShudiLi please QE check

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 26, 2024
@mburke5678 mburke5678 added this to the Continuous Release milestone Apr 26, 2024
@mburke5678
Copy link
Contributor

/lgtm

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 26, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@ShudiLi
Copy link
Member

ShudiLi commented Apr 28, 2024

/lgtm
thanks

@jmanthei
Copy link
Contributor

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 29, 2024
@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 29, 2024
@mburke5678 mburke5678 merged commit 5efae72 into openshift:main Apr 29, 2024
3 checks passed
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.14

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.15

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #75268

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 29, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #75269

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #75270

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mburke5678 mburke5678

@ShudiLi ShudiLi

Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alebedev87 @ocpdocs-previewbot @jmanthei @mburke5678 @ShudiLi @openshift-cherrypick-robot