Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-24949: Added procedure for real-time checkup #75211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sjhala-ccs
Copy link
Contributor

@sjhala-ccs sjhala-ccs commented Apr 26, 2024

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2024

@sjhala-ccs: This pull request references CNV-24949 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.16+

Issue: CNV-24949

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2024

@sjhala-ccs: This pull request references CNV-24949 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.16+

Issue: CNV-24949

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 26, 2024
@sjhala-ccs sjhala-ccs added CNV Label for all CNV PRs branch/enterprise-4.16 labels Apr 26, 2024
@sjhala-ccs sjhala-ccs added this to the Planned for 4.16 GA milestone Apr 26, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 26, 2024

🤖 Thu May 09 13:56:51 - Prow CI generated the docs preview:

https://75211--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/monitoring/virt-running-cluster-checkups.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2024

@sjhala-ccs: This pull request references CNV-24949 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.16+

Issue: CNV-24949

Link to docs preview: https://75211--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/monitoring/virt-running-cluster-checkups#virt-running-real-time-checkup_virt-running-cluster-checkups

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@orelmisan orelmisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @sjhala-ccs
Could you please add the table of possible inputs? (same as Table 1. DPDK checkup config map input parameters)

Could you please add a section for Building a container disk image for RHEL virtual machines same as in the DPDK checkup? @RamLavi and I will revisit it in a follow-up.

modules/virt-running-real-time-checkup.adoc Outdated Show resolved Hide resolved
modules/virt-running-real-time-checkup.adoc Outdated Show resolved Hide resolved
modules/virt-running-real-time-checkup.adoc Outdated Show resolved Hide resolved
modules/virt-running-real-time-checkup.adoc Show resolved Hide resolved
modules/virt-running-real-time-checkup.adoc Show resolved Hide resolved
modules/virt-running-real-time-checkup.adoc Outdated Show resolved Hide resolved
modules/virt-running-real-time-checkup.adoc Outdated Show resolved Hide resolved
modules/virt-running-real-time-checkup.adoc Outdated Show resolved Hide resolved
modules/virt-running-real-time-checkup.adoc Outdated Show resolved Hide resolved
modules/virt-running-real-time-checkup.adoc Outdated Show resolved Hide resolved
[id="virt-building-real-time-container-disk-image_{context}"]
= Building a container disk image for {op-system-base} virtual machines

You can build a custom {op-system-base-full} 8 OS image in `qcow2` format and use it to create a container disk image. You can store the container disk image in a registry that is accessible from your cluster and specify the image location in the `spec.param.vmUnderTestContainerDiskImage` attribute of the real-time checkup config map.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.CaseSensitiveTerms: Use 'operating system' rather than 'OS'. For more information, see RedHat.CaseSensitiveTerms.

+
where:

<UUID>-disk.qcow2:: Specifies the name of the custom image in `qcow2` format.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.CaseSensitiveTerms: Use 'QCOW2' rather than 'qcow2'. For more information, see RedHat.CaseSensitiveTerms.

|False

|`spec.param.oslatDuration`
|The duration for which the OS level thread latency test program runs.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.CaseSensitiveTerms: Use 'operating system' rather than 'OS'. For more information, see RedHat.CaseSensitiveTerms.

----
<1> The time, in hours and minutes, before the checkup fails.
<2> The container disk image for the VM under test.
<3> The duration for which the OS level thread latency test program runs.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.CaseSensitiveTerms: Use 'operating system' rather than 'OS'. For more information, see RedHat.CaseSensitiveTerms.

Copy link

openshift-ci bot commented May 9, 2024

@sjhala-ccs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.16 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants