New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBSDOCS-1011: Fix information about the user-workload-monitoring-conf… #75201
Conversation
@eromanova97: This pull request references OBSDOCS-1011 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Fri May 10 06:37:18 - Prow CI generated the docs preview: |
69e9682
to
87150a9
Compare
@eromanova97: This pull request references OBSDOCS-1011 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@eromanova97: This pull request references OBSDOCS-1011 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
9c0a9f4
to
7d20a49
Compare
modules/monitoring-creating-user-defined-workload-monitoring-configmap.adoc
Outdated
Show resolved
Hide resolved
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
for all the description in the PR
along with the note
they look good, but I think change
to
is better, that is more clear, since the |
1baa025
to
63c02d8
Compare
/lgtm |
@eromanova97: This pull request references OBSDOCS-1011 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label peer-review-needed |
/remove-label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, I just left a few ISG-based nits. Let me know when they're addressed and this PR will be ready to merge!
modules/monitoring-enabling-monitoring-for-user-defined-projects.adoc
Outdated
Show resolved
Hide resolved
modules/monitoring-enabling-monitoring-for-user-defined-projects.adoc
Outdated
Show resolved
Hide resolved
New changes are detected. LGTM label has been removed. |
Thank you @skopacz1 the comments are addressed now 👍 |
@eromanova97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Changes LGTM, merging |
/cherrypick enterprise-4.12 |
/cherrypick enterprise-4.13 |
/cherrypick enterprise-4.14 |
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.16 |
@skopacz1: #75201 failed to apply on top of branch "enterprise-4.12":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@skopacz1: #75201 failed to apply on top of branch "enterprise-4.13":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@skopacz1: new pull request created: #75773 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@skopacz1: new pull request created: #75774 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@skopacz1: new pull request created: #75775 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
enterprise-4.12
and laterIssue: OBSDOCS-1011
Links to docs preview:
QE review:
Additional information: