Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSM-6379 [OSSM][DOC] Update possible values for .general.logging.componentLevels #75142

Merged
merged 1 commit into from Apr 30, 2024
Merged

OSSM-6379 [OSSM][DOC] Update possible values for .general.logging.componentLevels #75142

merged 1 commit into from Apr 30, 2024

Conversation

gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Apr 25, 2024 •
edited

OSSM-6379 [OSSM][DOC] Update possible values for .general.logging.componentLevels

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OSSM-6379

Link to docs preview:
https://75142--ocpdocs-pr.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-reference-smcp.html#ossm-cr-general_ossm-reference

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2024
@ocpdocs-previewbot
Copy link

🤖 Thu Apr 25 14:29:12 - Prow CI generated the docs preview:

https://75142--ocpdocs-pr.netlify.app/openshift-dedicated/latest/service_mesh/v2x/ossm-reference-smcp.html
https://75142--ocpdocs-pr.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-reference-smcp.html
https://75142--ocpdocs-pr.netlify.app/openshift-rosa/latest/service_mesh/v2x/ossm-reference-smcp.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 25, 2024

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mkralik3
Copy link

LGTM

pbajjuri20
pbajjuri20 approved these changes Apr 29, 2024
View reviewed changes
Copy link

@pbajjuri20 pbajjuri20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..!

@gwynnemonahan
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 30, 2024
@mburke5678 mburke5678 added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 30, 2024
@mburke5678 mburke5678 added this to the Continuous Release milestone Apr 30, 2024
@mburke5678
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 30, 2024
@jldohmann jldohmann added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 30, 2024
jldohmann
jldohmann approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! LGTM

@jldohmann jldohmann merged commit e46ab85 into openshift:main Apr 30, 2024
3 checks passed
@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.16

@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.15

@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.14

@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.13

@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #75350

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 30, 2024
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #75351

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 30, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #75352

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #75353

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 30, 2024
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #75354

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 30, 2024
Merged
@jldohmann jldohmann removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jldohmann jldohmann jldohmann approved these changes

@pbajjuri20 pbajjuri20 pbajjuri20 approved these changes

Assignees

@mburke5678 mburke5678

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gwynnemonahan @ocpdocs-previewbot @mkralik3 @mburke5678 @jldohmann @openshift-cherrypick-robot @pbajjuri20