Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] AUTH-509: add unauth grp restore #75133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ibihim
Copy link

@ibihim ibihim commented Apr 25, 2024

Version(s):

Issue:

https://issues.redhat.com/browse/AUTH-509

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2024

@ibihim: This pull request references AUTH-509 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/AUTH-509

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 25, 2024
apiGroup: rbac.authorization.k8s.io
name: system:authenticated
- kind: Group
apiGroup: rbac.authorization.k8s.io
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.CaseSensitiveTerms: Use 'Kubernetes' rather than 'k8s'. For more information, see RedHat.CaseSensitiveTerms.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 25, 2024

🤖 Thu Apr 25 15:09:31 - Prow CI generated the docs preview:

https://75133--ocpdocs-pr.netlify.app/

@ibihim ibihim force-pushed the AUTH-509_unauthenticated-groups-crb branch from 719dc49 to 84042b1 Compare April 25, 2024 14:59
// Module included in the following assemblies:
//
// * authentication/???.adoc
// * post_installation_configuration/???.adoc
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, where to add it or if I should create entries completely. I would assume it would make sense to have it in authenticadtion / post_installation_configuration.

Copy link

openshift-ci bot commented Apr 25, 2024

@ibihim: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cbippley
Copy link
Contributor

cbippley commented Apr 25, 2024

This PR is now taken over by [[DOCS] AUTH-509 Reducing permissions for unauthenticated users for apiserver access #75173 ](#75173).

@adambkaplan
Copy link
Contributor

@ibihim we also need guidance on the BuildConfig webhook trigger doc. Unauthenticated calls are almost always needed when configuring webhooks on SCM systems like GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants