New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS-5954: Fixing typos in pre-reqs #74766
RHDEVDOCS-5954: Fixing typos in pre-reqs #74766
Conversation
@Dhruv-Soni11: This pull request references RHDEVDOCS-5954 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5954 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Thu May 09 11:28:01 - Prow CI generated the docs preview: |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5954 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
bc99072
to
0630c97
Compare
@Dhruv-Soni11: This pull request references RHDEVDOCS-5954 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5954 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5954 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5954 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5954 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Dhruv-Soni11: This pull request references RHDEVDOCS-5954 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more instances found here:
- https://docs.openshift.com/gitops/1.12/argocd_instance/setting-up-argocd-instance.html#gitops-argo-cd-installation_setting-up-argocd-instance
- https://docs.openshift.com/gitops/1.12/installing_gitops/installing-openshift-gitops.html#logging-in-to-the-argo-cd-instance-by-using-the-argo-cd-admin-account_installing-openshift-gitops
- https://docs.openshift.com/gitops/1.12/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery.html#prerequisites_using-argo-rollouts-for-progressive-deployment-delivery
- https://docs.openshift.com/gitops/1.12/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery.html#gitops-creating-rolloutmanager-custom-resource_using-argo-rollouts-for-progressive-deployment-delivery
- https://docs.openshift.com/gitops/1.12/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery.html#gitops-deleting-rolloutmanager-custom-resource_using-argo-rollouts-for-progressive-deployment-delivery
- https://docs.openshift.com/gitops/1.12/release_notes/gitops-release-notes.html#known-issues-1-12-0_gitops-release-notes
- https://docs.openshift.com/gitops/1.12/observability/monitoring/monitoring-argo-cd-custom-resource-workloads.html#prerequisites_monitoring-argo-cd-custom-resource-workloads
Thank you!
0630c97
to
b9cb6ca
Compare
b9cb6ca
to
9770220
Compare
Hi @varshab1210 and @eromanova97 - I have included the fixes for all of your comments. PTAL. |
9770220
to
3ce15c8
Compare
3ce15c8
to
4028269
Compare
/label needs-peer-review |
@Dhruv-Soni11: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label peer-review-needed |
4028269
to
2799779
Compare
2799779
to
e30ff59
Compare
Hi @jeana-redhat - Thanks for providing the fixes. I have incorporated your feedback in the latest changes. PTAL. Thank you :) |
@Dhruv-Soni11: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
LGTM, tag for merge review if you're ready to move it along :) |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; merging to gitops 1.9+.
/cherrypick gitops-docs-1.12 |
/cherrypick gitops-docs-1.11 |
/cherrypick gitops-docs-1.10 |
/cherrypick gitops-docs-1.9 |
@sheriff-rh: new pull request created: #75764 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@sheriff-rh: #74766 failed to apply on top of branch "gitops-docs-1.11":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@sheriff-rh: #74766 failed to apply on top of branch "gitops-docs-1.10":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@sheriff-rh: #74766 failed to apply on top of branch "gitops-docs-1.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Dhruv-Soni11 looks like cherrypicks failed from 1.9-1.11, please resolve manual cherry picks and place them back in the merge queue, referencing this PR in the description. Thanks! |
Version(s): GitOps 1.9, GitOps 1.10, GitOps 1.11, GitOps 1.12
Issue: https://issues.redhat.com/browse/RHDEVDOCS-5954
Link to docs preview: I have made the changes in a lot of places in the content. So, I am just adding a sample link for the changes at one instance: https://74766--ocpdocs-pr.netlify.app/openshift-gitops/latest/observability/monitoring/monitoring-argo-cd-instances.html
SME review: @reginapizza
QE review: @varshab1210
Internal Peer review: @eromanova97
Peer review:
QE review:
Additional information: This PR also includes the changes in content for correct policy for user level permissions from the following PR. Further details for this issue are available in the following: #69134