Let errors occur when copying the DPU CNI

[wizhaoredhat]

It is most likely that we will in the future include a command line argument for the CNI path since different cluster types will have different CNI locations.

For now remove the check for "writeable()" and simplify the code to just attempt to copy and make executable. Errors are logged and not act upon.

The writeable() code also had a bug where it would check for the file and not the directory.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wizhaoredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wizhaoredhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@wizhaoredhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vrindle]

/lgtm

[wizhaoredhat]

2024-04-29T13:54:25Z    INFO    Daemon Init     Daemon init
2024-04-29T13:54:25Z    ERROR   Daemon Init     Failed to prepare CNI binary in /opt    {"error": "open /opt/cni/bin/dpu-cni: read-only file system"}
main.main
        /workspace/daemon/main.go:118
runtime.main
        /usr/lib/golang/src/runtime/proc.go:267
2024-04-29T13:54:25Z    INFO    HostDaemon      starting HostDaemon     {"devflag": false, "cniServerPath": "/var/run/dpu-daemon/dpu-cni/dpu-cni-server.sock"}
I0429 13:54:25.990135  788336 cniserver.go:320] DPU CNI Server creating new router.
I0429 13:54:25.990169  788336 cniserver.go:40] Removing /var/run/dpu-daemon/dpu-cni
I0429 13:54:25.990224  788336 cniserver.go:65] Creating /var/run/dpu-daemon/dpu-cni
I0429 13:54:25.990326  788336 cniserver.go:82] Listen on socket path: /var/run/dpu-daemon/dpu-cni/dpu-cni-server.sock

Logs look like this on a CoreOS based deployment.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build dpu-cni-container-v4.16.0-202404291547.p0.g530b9ac.assembly.stream.el9 for distgit dpu-cni.
All builds following this will include this PR.