OCPBUGS-32476: Import from Git allow users to import an app with Build option Pipeline also when no Pipeline is available

[lokanandaprabhu]

Fixes:
https://issues.redhat.com/browse/OCPBUGS-32476

Analysis / Root cause:
Validation was not added to check if any pipeline template is selected if user choose Pipeline from the cluster

Solution Description:
Added the validation to check if build type is Pipeline and pipeline type is not PAC to check whether pipeline template is selected or not. If not create button will be disabled

Screen shots / Gifs for design review:

----When Just after Pipeline operator is installed---

Screen.Recording.2024-05-15.at.11.00.54.AM.mov

--- Import from Git form---
https://github.com/openshift/console/assets/102503482/ef7d7127-795a-4ff8-bdbf-4563f78ccfed

---Adding serverless function without Pipeline template created---
https://github.com/openshift/console/assets/102503482/f87d01e6-32e9-4aa8-b5c2-835b16b50462

---Create serverless function form---
https://github.com/openshift/console/assets/102503482/e7c4ce2a-e4b8-4b2c-9542-15f6cd048ab2

Unit test coverage report:
NA

Test setup:

1. Install OpenShift Local
2. Install Pipelines Opeartor
3. Import from Git and select Pipeline as option

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32476, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-32476

Analysis / Root cause:
Validation was not added to check if any pipeline template is selected if user choose Pipeline from the cluster

Solution Description:
Added the validation to check if build type is Pipeline and pipeline type is not PAC to check whether pipeline template is selected or not. If not create button will be disabled

Screen shots / Gifs for design review:

----When Just after Pipeline operator is installed---

Screen.Recording.2024-05-15.at.11.00.54.AM.mov

--- Import from Git form---
https://github.com/openshift/console/assets/102503482/ef7d7127-795a-4ff8-bdbf-4563f78ccfed

---Adding serverless function without Pipeline template created---
https://github.com/openshift/console/assets/102503482/f87d01e6-32e9-4aa8-b5c2-835b16b50462

---Create serverless function form---
https://github.com/openshift/console/assets/102503482/e7c4ce2a-e4b8-4b2c-9542-15f6cd048ab2

Unit test coverage report:
NA

Test setup:

1. Install OpenShift Local
2. Install Pipelines Opeartor
3. Import from Git and select Pipeline as option

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lokanandaprabhu]

/jira refresh

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32476, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lokanandaprabhu]

/cc @vikram-raj

[vikram-raj]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [lokanandaprabhu,vikram-raj]
• frontend/packages/pipelines-plugin/OWNERS [lokanandaprabhu,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lokanandaprabhu]

/retest

[openshift-ci-robot]

@lokanandaprabhu: Jira Issue OCPBUGS-32476: All pull requests linked via external trackers have merged:

• openshift/console#13853

Jira Issue OCPBUGS-32476 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-32476

Analysis / Root cause:
Validation was not added to check if any pipeline template is selected if user choose Pipeline from the cluster

Solution Description:
Added the validation to check if build type is Pipeline and pipeline type is not PAC to check whether pipeline template is selected or not. If not create button will be disabled

Screen shots / Gifs for design review:

----When Just after Pipeline operator is installed---

Screen.Recording.2024-05-15.at.11.00.54.AM.mov

--- Import from Git form---
https://github.com/openshift/console/assets/102503482/ef7d7127-795a-4ff8-bdbf-4563f78ccfed

---Adding serverless function without Pipeline template created---
https://github.com/openshift/console/assets/102503482/f87d01e6-32e9-4aa8-b5c2-835b16b50462

---Create serverless function form---
https://github.com/openshift/console/assets/102503482/e7c4ce2a-e4b8-4b2c-9542-15f6cd048ab2

Unit test coverage report:
NA

Test setup:

1. Install OpenShift Local
2. Install Pipelines Opeartor
3. Import from Git and select Pipeline as option

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lokanandaprabhu]

/cherrypick release-4.16

[openshift-cherrypick-robot]

@lokanandaprabhu: new pull request created: #13884

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.