OCPBUGS-33636: Updating the secrets using Form editor displays an unknown warning message #13852

cyril-ui-developer · 2024-05-14T20:46:46Z

Before:

After:

openshift-ci-robot · 2024-05-14T20:46:51Z

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-33636, which is invalid:

expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cyril-ui-developer · 2024-05-14T20:48:33Z

/jira refresh

openshift-ci-robot · 2024-05-14T20:48:39Z

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-33636, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

parth-gr

lgtm

rhamilto

/lgtm

spadgett · 2024-05-16T15:47:33Z

frontend/public/components/secrets/create-secret.tsx

@@ -1322,7 +1322,8 @@ export const SecretLoadingWrapper = withTranslation()(
      if (!secretTypeAbstraction) {
        return <LoadingBox />;
      }
-      const fixed = _.reduce(fixedKeys, (acc, k) => ({ ...acc, k: _.get(obj.data, k) }), {});
+      const fixed = fixedKeys.reduce((acc, k) => ({ ...acc, [k]: obj.data?.[k] }), {});


Is fixedKeys always defined?

Good catch, @spadgett. @cyril-ui-developer, might need an update here. Gonna put a hold on this.

/hold

@spadgett @rhamilto Not sure but looking at the type I think so. But I can add ? operator it safer.

openshift-bot · 2024-05-17T09:45:16Z

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

openshift-ci-robot · 2024-05-17T09:45:44Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-33636, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yanpzhan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rhamilto · 2024-05-17T14:57:45Z

/hold cancel
/lgtm

openshift-ci · 2024-05-17T14:58:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, parth-gr, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2024-05-17T15:04:24Z

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

openshift-ci-robot · 2024-05-17T15:05:38Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-33636, which is invalid:

expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cyril-ui-developer · 2024-05-17T16:55:55Z

/retest

openshift-ci · 2024-05-17T22:04:45Z

@cyril-ui-developer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

cyril-ui-developer · 2024-05-20T02:16:33Z

/label acknowledge-critical-fixes-only

cyril-ui-developer · 2024-05-20T02:17:03Z

/retest

rhamilto · 2024-05-20T11:44:09Z

/jira refresh

openshift-ci-robot · 2024-05-20T11:44:14Z

@rhamilto: This pull request references Jira Issue OCPBUGS-33636, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.17.0) matches configured target version for branch (4.17.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yanpzhan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-05-20T18:59:44Z

@cyril-ui-developer: Jira Issue OCPBUGS-33636: All pull requests linked via external trackers have merged:

openshift/console#13852

Jira Issue OCPBUGS-33636 has been moved to the MODIFIED state.

In response to this:

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cyril-ui-developer · 2024-05-20T19:18:14Z

/cherry-pick release-4.16

openshift-cherrypick-robot · 2024-05-20T19:18:58Z

@cyril-ui-developer: new pull request created: #13873

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2024-05-20T22:19:46Z

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.17.0-202405202113.p0.g99985fa.assembly.stream.el9 for distgit openshift-enterprise-console.
All builds following this will include this PR.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 14, 2024

openshift-ci bot requested review from jeff-phillips-18 and spadgett May 14, 2024 20:47

openshift-ci bot added the component/core Related to console core functionality label May 14, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 14, 2024

openshift-ci bot requested a review from yapei May 14, 2024 20:48

cyril-ui-developer force-pushed the secret-edit-form-incorrect-req-obj branch from 093daaf to 7345d54 Compare May 15, 2024 11:16

cyril-ui-developer changed the title ~~OCPBUGS-33636: Updating the secrets using Form editor displays the an unknown warning message~~ OCPBUGS-33636: Updating the secrets using Form editor displays an unknown warning message May 15, 2024

parth-gr approved these changes May 15, 2024

View reviewed changes

rhamilto approved these changes May 15, 2024

View reviewed changes

openshift-ci bot assigned rhamilto May 15, 2024

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 15, 2024

spadgett reviewed May 16, 2024

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024

openshift-ci bot requested a review from yanpzhan May 17, 2024 09:45

secret-edit-form-incorrect-req-obj

053772f

cyril-ui-developer force-pushed the secret-edit-form-incorrect-req-obj branch from 7345d54 to 053772f Compare May 17, 2024 14:20

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 17, 2024

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 17, 2024

openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 17, 2024

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 20, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 20, 2024

openshift-merge-bot bot merged commit 99985fa into openshift:master May 20, 2024
6 checks passed

openshift-cherrypick-robot mentioned this pull request May 20, 2024

[release-4.16] OCPBUGS-33989: Updating the secrets using Form editor displays an unknown warning message #13873

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-33636: Updating the secrets using Form editor displays an unknown warning message #13852

OCPBUGS-33636: Updating the secrets using Form editor displays an unknown warning message #13852

cyril-ui-developer commented May 14, 2024

openshift-ci-robot commented May 14, 2024

Before:

After:

cyril-ui-developer commented May 14, 2024

openshift-ci-robot commented May 14, 2024

parth-gr left a comment

rhamilto left a comment

spadgett May 16, 2024

rhamilto May 16, 2024

cyril-ui-developer May 17, 2024

openshift-bot commented May 17, 2024

openshift-ci-robot commented May 17, 2024

rhamilto commented May 17, 2024

openshift-ci bot commented May 17, 2024

openshift-bot commented May 17, 2024

openshift-ci-robot commented May 17, 2024

cyril-ui-developer commented May 17, 2024

openshift-ci bot commented May 17, 2024

cyril-ui-developer commented May 20, 2024

cyril-ui-developer commented May 20, 2024

rhamilto commented May 20, 2024

openshift-ci-robot commented May 20, 2024

openshift-ci-robot commented May 20, 2024

Before:

After:

cyril-ui-developer commented May 20, 2024

openshift-cherrypick-robot commented May 20, 2024

openshift-bot commented May 20, 2024

OCPBUGS-33636: Updating the secrets using Form editor displays an unknown warning message #13852

OCPBUGS-33636: Updating the secrets using Form editor displays an unknown warning message #13852

Conversation

cyril-ui-developer commented May 14, 2024

Before:

After:

openshift-ci-robot commented May 14, 2024

Before:

After:

cyril-ui-developer commented May 14, 2024

openshift-ci-robot commented May 14, 2024

parth-gr left a comment

Choose a reason for hiding this comment

rhamilto left a comment

Choose a reason for hiding this comment

spadgett May 16, 2024

Choose a reason for hiding this comment

rhamilto May 16, 2024

Choose a reason for hiding this comment

cyril-ui-developer May 17, 2024

Choose a reason for hiding this comment

openshift-bot commented May 17, 2024

openshift-ci-robot commented May 17, 2024

rhamilto commented May 17, 2024

openshift-ci bot commented May 17, 2024

openshift-bot commented May 17, 2024

openshift-ci-robot commented May 17, 2024

cyril-ui-developer commented May 17, 2024

openshift-ci bot commented May 17, 2024

cyril-ui-developer commented May 20, 2024

cyril-ui-developer commented May 20, 2024

rhamilto commented May 20, 2024

openshift-ci-robot commented May 20, 2024

openshift-ci-robot commented May 20, 2024

Before:

After:

cyril-ui-developer commented May 20, 2024

openshift-cherrypick-robot commented May 20, 2024

openshift-bot commented May 20, 2024