-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.14] OCPBUGS-33635: restrict Masthead logo to max-height to 60px #13847
[release-4.14] OCPBUGS-33635: restrict Masthead logo to max-height to 60px #13847
Conversation
@rhamilto: This pull request references Jira Issue OCPBUGS-33635, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
/cherry-pick release-4.13 |
@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
1 similar comment
/retest |
/jira refresh |
@rhamilto: This pull request references Jira Issue OCPBUGS-33635, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Checked on the cluster launched against the pr, now a big logo could be restricted in max-height of 60px, the bug is fixed. |
@rhamilto: This pull request references Jira Issue OCPBUGS-33635, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rhamilto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
bf287a8
into
openshift:release-4.14
@rhamilto: Jira Issue OCPBUGS-33635: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-33635 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rhamilto: #13847 failed to apply on top of branch "release-4.13":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-console-container-v4.14.0-202405160608.p0.gbf287a8.assembly.stream.el8 for distgit openshift-enterprise-console. |
@@ -81,7 +81,7 @@ export const Masthead = React.memo(({ isMastheadStacked, isNavOpen, onNavToggle | |||
</MastheadToggle> | |||
<MastheadMain> | |||
<MastheadBrand {...logoProps}> | |||
<Brand src={details.logoImg} alt={details.productName} /> | |||
<Brand src={details.logoImg} alt={details.productName} data-test="brand-image" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was unnecessary since I removed the related Cypress test update in order to pass in CI.
Fix included in accepted release 4.14.0-0.nightly-2024-05-16-121259 |
No description provided.